From ada5a5beaa2c20706766bacdebdc167d0af2fc4b Mon Sep 17 00:00:00 2001 From: Xavier-Do Date: Thu, 14 Nov 2024 13:23:44 +0100 Subject: [PATCH] [FIX] runbot: fix reclean --- runbot/models/build_error.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/runbot/models/build_error.py b/runbot/models/build_error.py index 02d0de49..fcd9aec0 100644 --- a/runbot/models/build_error.py +++ b/runbot/models/build_error.py @@ -504,8 +504,11 @@ class BuildErrorContent(models.Model): # merge identical errors errors_content_by_fingerprint = self.env['runbot.build.error.content'].search([('fingerprint', 'in', list(changed_fingerprints))]) + to_merge = [] for fingerprint in changed_fingerprints: - errors_content_to_merge = errors_content_by_fingerprint.filtered(lambda r: r.fingerprint == fingerprint) + to_merge.append(errors_content_by_fingerprint.filtered(lambda r: r.fingerprint == fingerprint)) + # this must be done in other iteration since filtered may fail because of unlinked records from _merge + for errors_content_to_merge in to_merge: errors_content_to_merge._merge()