From b1ce1e82e03a303de7b8aa8c693973a9412b01a1 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Thu, 23 Jan 2020 10:08:55 +0100 Subject: [PATCH] [REM] runbot_merge: str override on pull_request Interaction of CacheMiss and BaseModel is fucked, leading to an infinite loop when trying to provide useful __str__ on a model (by accessing model fields). --- runbot_merge/models/pull_requests.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/runbot_merge/models/pull_requests.py b/runbot_merge/models/pull_requests.py index 9612c5eb..24adcd65 100644 --- a/runbot_merge/models/pull_requests.py +++ b/runbot_merge/models/pull_requests.py @@ -575,18 +575,6 @@ class PullRequests(models.Model): for p in self ] - def __str__(self): - if len(self) == 0: - separator = '' - elif len(self) == 1: - separator = ' ' - else: - separator = 's ' - return '' % (separator, ' '.join( - '{0.id} ({0.display_name})'.format(p) - for p in self - )) - # missing link to other PRs @api.depends('priority', 'state', 'squash', 'merge_method', 'batch_id.active', 'label') def _compute_is_blocked(self):