[IMP] runbot: rebuild using POST request

Force rebuild links were using GET method. We don't want crawlers to rebuild old builds....
This commit is contained in:
Martin Trigaux 2014-09-23 10:04:15 +02:00
parent 64a686aded
commit b84964d9f7
2 changed files with 3 additions and 3 deletions

View File

@ -1131,7 +1131,7 @@ class RunbotController(http.Controller):
#context['level'] = level
return request.render("runbot.build", context)
@http.route(['/runbot/build/<build_id>/force'], type='http', auth="public", website=True)
@http.route(['/runbot/build/<build_id>/force'], type='http', auth="public", method='POST')
def build_force(self, build_id, **post):
registry, cr, uid, context = request.registry, request.cr, 1, request.context
repo_id = registry['runbot.build'].force(cr, uid, [int(build_id)])

View File

@ -250,7 +250,7 @@
<button class="btn btn-default dropdown-toggle" data-toggle="dropdown"><i class="fa fa-cog"/><span class="caret"></span></button>
<ul class="dropdown-menu" role="menu">
<li t-if="bu['result']=='skipped'">
<a t-attf-href="/runbot/build/{{bu['id']}}/force">Force Build<i class="fa fa-level-up"> </i></a>
<a t-attf-href="#" t-attf-onclick="$.post('/runbot/build/{{bu['id']}}/force')">Force Build<i class="fa fa-level-up"> </i></a>
</li>
<t t-if="bu['state']=='running'">
<li><a t-attf-href="http://{{bu['domain']}}/?db={{bu['real_dest']}}-all">Connect all <i class="fa fa-sign-in"></i></a></li>
@ -258,7 +258,7 @@
<li><a t-attf-href="http://{{bu['domain']}}/">Connect <i class="fa fa-sign-in"></i></a></li>
</t>
<li t-if="bu['state'] in ['done','running'] and bu_index==0">
<a t-attf-href="/runbot/build/#{bu['id']}/force">Rebuild <i class="fa fa-refresh"/></a>
<a t-t-attf-href="#" t-attf-onclick="$.post('/runbot/build/#{bu['id']}/force')">Rebuild <i class="fa fa-refresh"/></a>
</li>
<li t-if="bu['state']!='testing' and bu['state']!='pending'" class="divider"></li>
<li><a t-attf-href="/runbot/build/{{bu['id']}}">Logs <i class="fa fa-file-text-o"/></a></li>