From c0055615464ed472638e0d8369c08abcb7eb6b78 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Fri, 17 Apr 2020 07:40:22 +0200 Subject: [PATCH] [FIX] runbot_merge: mistake in logging parameter When it updated tagging e82de3136b1ca02ec125c45c0cbd80bec96ea28c also incorrectly replaced a `pr` by `pr.display_name`, probably leftover from an attempt to update a callsite from `str(pr)` to `pr.display_name` which I missed when reverting that. Anyway at that section, `pr` is an integer (as it comes from an SQL query) not an object. --- runbot_merge/models/pull_requests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runbot_merge/models/pull_requests.py b/runbot_merge/models/pull_requests.py index b1d1ab43..3dca4dcc 100644 --- a/runbot_merge/models/pull_requests.py +++ b/runbot_merge/models/pull_requests.py @@ -118,7 +118,7 @@ class Project(models.Model): except Exception: _logger.exception( "Error while trying to change the tags of %s#%s from %s to %s", - repo.name, pr.display_name, remove, add, + repo.name, pr, remove, add, ) else: to_remove.extend(ids)