[IMP] runbot_merge: support @ and # prefixes to delegate= logins

runbot_merge/models/pull_requests.py

@@ -469,7 +469,10 @@ class PullRequests(models.Model):
             if flag == '+':
                 return ('delegate', True)
             elif param:
-                return ('delegate', param.split(','))
+                return ('delegate', [
+                    p.lstrip('#@')
+                    for p in param.split(',')
+                ])
         elif name in ('p', 'priority'):
             if param in ('0', '1', '2'):
                 return ('priority', int(param))

runbot_merge/tests/test_basic.py

@@ -1674,6 +1674,22 @@ class TestReviewing(object):
             ('number', '=', prx.number)
         ]).state == 'ready'
 
+    def test_delegate_prefixes(self, env, repo):
+        m = repo.make_commit(None, 'initial', None, tree={'m': 'm'})
+        repo.make_ref('heads/master', m)
+
+        c = repo.make_commit(m, 'first', None, tree={'m': 'c'})
+        prx = repo.make_pr('title', None, target='master', ctid=c, user='user')
+        prx.post_comment('hansen delegate=foo,@bar,#baz', user='reviewer')
+
+        pr = env['runbot_merge.pull_requests'].search([
+            ('repository.name', '=', repo.name),
+            ('number', '=', prx.number)
+        ])
+
+        assert {d.github_login for d in pr.delegates} == {'foo', 'bar', 'baz'}
+
+
     def test_actual_review(self, env, repo):
         """ treat github reviews as regular comments
         """