From ca8ee428f845c3237e0c3beab5433791b48f01dd Mon Sep 17 00:00:00 2001
From: Xavier-Do <xdo@odoo.com>
Date: Tue, 8 Feb 2022 10:05:37 +0100
Subject: [PATCH] [REF] runbot: move all menu to a single file

---
 runbot/__manifest__.py                     |  1 +
 runbot/views/branch_views.xml              |  9 ----
 runbot/views/build_error_views.xml         | 23 --------
 runbot/views/build_views.xml               |  3 --
 runbot/views/bundle_views.xml              |  6 ---
 runbot/views/codeowner_views.xml           |  7 ---
 runbot/views/commit_views.xml              |  8 +--
 runbot/views/config_views.xml              | 21 --------
 runbot/views/dashboard_views.xml           | 21 --------
 runbot/views/dockerfile_views.xml          |  9 ----
 runbot/views/error_log_views.xml           | 14 -----
 runbot/views/host_views.xml                |  7 ---
 runbot/views/menus.xml                     | 63 ++++++++++++++++++++++
 runbot/views/repo_views.xml                | 44 ---------------
 runbot/views/res_config_settings_views.xml |  3 +-
 runbot/views/stat_views.xml                | 54 ++++++-------------
 runbot/views/upgrade.xml                   | 14 -----
 runbot/views/warning_views.xml             |  8 ---
 runbot/wizards/stat_regex_wizard_views.xml |  9 +---
 19 files changed, 83 insertions(+), 241 deletions(-)
 create mode 100644 runbot/views/menus.xml

diff --git a/runbot/__manifest__.py b/runbot/__manifest__.py
index c7b63641..7ec2f1b5 100644
--- a/runbot/__manifest__.py
+++ b/runbot/__manifest__.py
@@ -54,6 +54,7 @@
         'views/warning_views.xml',
         'views/custom_trigger_wizard_views.xml',
         'wizards/stat_regex_wizard_views.xml',
+        'views/menus.xml',
     ],
     'license': 'LGPL-3',
 }
diff --git a/runbot/views/branch_views.xml b/runbot/views/branch_views.xml
index fa36568e..e77efb32 100644
--- a/runbot/views/branch_views.xml
+++ b/runbot/views/branch_views.xml
@@ -43,14 +43,5 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem name="Runbot" id="runbot_menu_root"/>
-
-    <menuitem
-        name="Branches"
-        id="runbot_menu_branch_tree"
-        parent="runbot_menu_root"
-        sequence="20"
-        action="open_view_branch_tree"
-        />
   </data>
 </odoo>
diff --git a/runbot/views/build_error_views.xml b/runbot/views/build_error_views.xml
index 64e980e7..cfd0e644 100644
--- a/runbot/views/build_error_views.xml
+++ b/runbot/views/build_error_views.xml
@@ -189,28 +189,5 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem
-        name="Manage errors"
-        id="runbot_menu_manage_errors"
-        parent="runbot_menu_root"
-        sequence="40"
-        />
-
-    <menuitem
-        name="Build errors"
-        id="runbot_menu_build_error_tree"
-        parent="runbot_menu_manage_errors"
-        sequence="10"
-        action="open_view_build_error_tree"
-        />
-
-    <menuitem
-        name="Error regex"
-        id="runbot_menu_error_regex_tree"
-        parent="runbot_menu_manage_errors"
-        sequence="20"
-        action="open_view_error_regex"
-        />
-
   </data>
 </odoo>
diff --git a/runbot/views/build_views.xml b/runbot/views/build_views.xml
index 061e7b0d..2bdc19a3 100644
--- a/runbot/views/build_views.xml
+++ b/runbot/views/build_views.xml
@@ -142,8 +142,5 @@
         <field name="res_model">runbot.build.params</field>
         <field name="view_mode">tree,form</field>
     </record>
-    <menuitem id="menu_build" name="Build" parent="runbot_menu_root"/>
-    <menuitem id="menu_build_build" action="action_build" parent="menu_build"/>
-    <menuitem id="menu_build_params" action="action_build_params" parent="menu_build"/>
   </data>
 </odoo>
\ No newline at end of file
diff --git a/runbot/views/bundle_views.xml b/runbot/views/bundle_views.xml
index ce0d7a50..8ab8a1bc 100644
--- a/runbot/views/bundle_views.xml
+++ b/runbot/views/bundle_views.xml
@@ -165,11 +165,5 @@
         <field name="res_model">runbot.batch</field>
         <field name="view_mode">tree,form</field>
     </record>
-
-    <menuitem id="menu_bundle" name="Bundle" parent="runbot_menu_root"/>
-    <menuitem id="menu_bundle_bundle" action="action_bundle" parent="menu_bundle"/>
-    <menuitem id="menu_bundle_project" action="action_bundle_project" parent="menu_bundle"/>
-    <menuitem id="menu_bundle_version" action="action_bundle_version" parent="menu_bundle"/>
-    <menuitem id="menu_bundle_batch" action="action_bundle_batch" parent="menu_bundle"/>
   </data>
 </odoo>
\ No newline at end of file
diff --git a/runbot/views/codeowner_views.xml b/runbot/views/codeowner_views.xml
index f8316b4b..1b83f5ab 100644
--- a/runbot/views/codeowner_views.xml
+++ b/runbot/views/codeowner_views.xml
@@ -42,12 +42,5 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem
-        name="CodeOwners"
-        id="runbot_menu_codeowner_tree"
-        parent="runbot_menu_manage_errors"
-        sequence="90"
-        action="open_view_codeowner_tree"
-        />
   </data>
 </odoo>
diff --git a/runbot/views/commit_views.xml b/runbot/views/commit_views.xml
index 133e9fb4..1b921845 100644
--- a/runbot/views/commit_views.xml
+++ b/runbot/views/commit_views.xml
@@ -59,12 +59,6 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem
-        name="Commits"
-        id="runbot_menu_commit_tree"
-        parent="runbot_menu_root"
-        sequence="20"
-        action="open_view_commit_tree"
-        />
+
   </data>
 </odoo>
diff --git a/runbot/views/config_views.xml b/runbot/views/config_views.xml
index 759a4264..0343ebee 100644
--- a/runbot/views/config_views.xml
+++ b/runbot/views/config_views.xml
@@ -189,28 +189,7 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem
-        name="Configs"
-        id="runbot_menu_configs"
-        parent="runbot_menu_root"
-        sequence="30"
-        />
 
-    <menuitem
-        name="Build Configs"
-        id="runbot_menu_job_config_tree"
-        parent="runbot_menu_configs"
-        sequence="10"
-        action="open_view_job_config_tree"
-        />
-
-    <menuitem
-        name="Build Config Step"
-        id="runbot_menu_job_tree"
-        parent="runbot_menu_configs"
-        sequence="20"
-        action="open_view_job_tree"
-        />
 
   </data>
 </odoo>
diff --git a/runbot/views/dashboard_views.xml b/runbot/views/dashboard_views.xml
index f1eda30d..3e4ab908 100644
--- a/runbot/views/dashboard_views.xml
+++ b/runbot/views/dashboard_views.xml
@@ -125,26 +125,5 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem
-        name="Runbot Teams"
-        id="runbot_menu_team_tree"
-        parent="runbot_menu_manage_errors"
-        sequence="30"
-        action="open_view_runbot_team"
-        />
-    <menuitem
-        name="Runbot Dashboards"
-        id="runbot_menu_runbot_dashboard_tree"
-        parent="runbot_menu_manage_errors"
-        sequence="40"
-        action="open_view_runbot_dashboard"
-        />
-    <menuitem
-        name="Runbot Dashboard Tiles"
-        id="runbot_menu_runbot_dashboard_tile_tree"
-        parent="runbot_menu_manage_errors"
-        sequence="50"
-        action="open_view_runbot_dashboard_tile"
-        />
   </data>
 </odoo>
diff --git a/runbot/views/dockerfile_views.xml b/runbot/views/dockerfile_views.xml
index cdfb68f9..ae9c3363 100644
--- a/runbot/views/dockerfile_views.xml
+++ b/runbot/views/dockerfile_views.xml
@@ -73,14 +73,5 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem
-        id="menu_docker"
-        name="Docker"
-        parent="runbot_menu_root"
-        sequence="34"
-    />
-
-    <menuitem id="menu_dockerfile" name="Dockerfiles" parent="menu_docker" action="open_view_dockerfile_tree" sequence="10"/>
-
   </data>
 </odoo>
diff --git a/runbot/views/error_log_views.xml b/runbot/views/error_log_views.xml
index 4b0d959a..b2e63c7e 100644
--- a/runbot/views/error_log_views.xml
+++ b/runbot/views/error_log_views.xml
@@ -86,19 +86,5 @@
         <field name="context">{'search_default_sticky_bundles': True, 'search_default_failed_builds': True, 'search_default_log_date': True}</field>
     </record>
 
-    <menuitem
-      id="runbot_log_menu"
-      name="Logs"
-      parent="runbot_menu_root"
-      sequence="50"
-    />
-
-    <menuitem
-        name="Error Logs"
-        id="runbot_menu_error_logs"
-        parent="runbot_log_menu"
-        sequence="20"
-        action="open_view_error_log_tree"
-    />
   </data>
 </odoo>
diff --git a/runbot/views/host_views.xml b/runbot/views/host_views.xml
index b8b08d6a..1689f205 100644
--- a/runbot/views/host_views.xml
+++ b/runbot/views/host_views.xml
@@ -47,12 +47,5 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem
-        name="Build Hosts"
-        id="runbot_menu_host_tree"
-        parent="runbot_menu_root"
-        sequence="32"
-        action="open_view_host_tree"
-        />
   </data>
 </odoo>
diff --git a/runbot/views/menus.xml b/runbot/views/menus.xml
new file mode 100644
index 00000000..bf78e76b
--- /dev/null
+++ b/runbot/views/menus.xml
@@ -0,0 +1,63 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<odoo> 
+    <menuitem name="Runbot" id="runbot_menu_root"/>
+
+    <menuitem name="Settings" id="menu_runbot_global_settings" parent="runbot_menu_root" sequence="0" action="action_runbot_configuration" groups="base.group_system"/>
+
+    <menuitem name="Build" id="menu_build" parent="runbot_menu_root"/>
+    <menuitem action="action_build" id="menu_build_build" parent="menu_build"/>
+    <menuitem action="action_build_params" id="menu_build_params" parent="menu_build"/>
+
+    <menuitem name="Bundle" id="menu_bundle" parent="runbot_menu_root"/>
+    <menuitem id="menu_bundle_bundle" action="action_bundle" parent="menu_bundle"/>
+    <menuitem id="menu_bundle_project" action="action_bundle_project" parent="menu_bundle"/>
+    <menuitem id="menu_bundle_version" action="action_bundle_version" parent="menu_bundle"/>
+    <menuitem id="menu_bundle_batch" action="action_bundle_batch" parent="menu_bundle"/>
+
+    <menuitem name="Repos" id="runbot_menu_repos_main" parent="runbot_menu_root"/>
+    <menuitem id="runbot_menu_repos" parent="runbot_menu_repos_main" sequence="10" action="runbot_repos_action"/>
+    <menuitem id="runbot_menu_remotes" parent="runbot_menu_repos_main" sequence="20" action="runbot_remotes_action"/>
+    <menuitem id="runbot_menu_trigger" parent="runbot_menu_repos_main" sequence="30" action="runbot_triggers_action"/>
+    <menuitem id="runbot_menu_trigger_category" parent="runbot_menu_repos_main" sequence="40" action="runbot_triggers_category_action"/>
+
+    <menuitem name="Branches" id="runbot_menu_branch_tree" parent="runbot_menu_root" sequence="20" action="open_view_branch_tree"/>
+
+    <menuitem name="Commits" id="runbot_menu_commit_tree" parent="runbot_menu_root" sequence="20" action="open_view_commit_tree"/>
+
+    <menuitem name="Configs" id="runbot_menu_configs" parent="runbot_menu_root" sequence="30"/>
+    <menuitem name="Build Configs" id="runbot_menu_job_config_tree" parent="runbot_menu_configs" sequence="10" action="open_view_job_config_tree"/>
+    <menuitem name="Build Config Step" id="runbot_menu_job_tree" parent="runbot_menu_configs" sequence="20" action="open_view_job_tree"/>
+    <menuitem name="Upgrade Exceptions" id="runbot_menu_upgrade_exceptions_tree" parent="runbot_menu_configs" sequence="30" action="open_view_upgrade_exception_tree"/>
+    <menuitem name="Upgrade Regexes" id="runbot_menu_upgrade_regex_tree" parent="runbot_menu_configs" sequence="30" action="open_view_upgrade_regex_tree"/>
+
+    <menuitem name="Build Hosts" id="runbot_menu_host_tree" parent="runbot_menu_root" sequence="32" action="open_view_host_tree"/>
+
+    <menuitem name="Docker" id="menu_docker" parent="runbot_menu_root" sequence="34"/>
+    <menuitem name="Dockerfiles" id="menu_dockerfile" parent="menu_docker" action="open_view_dockerfile_tree" sequence="10"/>
+
+    <menuitem name="Manage errors" id="runbot_menu_manage_errors" parent="runbot_menu_root" sequence="40"/>
+    <menuitem name="Build errors" id="runbot_menu_build_error_tree" parent="runbot_menu_manage_errors" sequence="10" action="open_view_build_error_tree"/>
+    <menuitem name="Error regex" id="runbot_menu_error_regex_tree" parent="runbot_menu_manage_errors" sequence="20" action="open_view_error_regex"/>
+    <menuitem name="Runbot Teams" id="runbot_menu_team_tree" parent="runbot_menu_manage_errors" sequence="30" action="open_view_runbot_team"/>
+    <menuitem name="Runbot Dashboards" id="runbot_menu_runbot_dashboard_tree" parent="runbot_menu_manage_errors" sequence="40" action="open_view_runbot_dashboard"/>
+    <menuitem name="Runbot Dashboard Tiles" id="runbot_menu_runbot_dashboard_tile_tree" parent="runbot_menu_manage_errors" sequence="50" action="open_view_runbot_dashboard_tile"/>
+    <menuitem name="CodeOwners" id="runbot_menu_codeowner_tree" parent="runbot_menu_manage_errors" sequence="90" action="open_view_codeowner_tree"/>
+
+    <menuitem name="Logs" id="runbot_log_menu" parent="runbot_menu_root" sequence="50"/>
+    <menuitem name="Error Logs" id="runbot_menu_error_logs" parent="runbot_log_menu" sequence="20" action="open_view_error_log_tree"/>
+
+    <menuitem name="Build Statistics" id="runbot_menu_stat_root" parent="runbot_menu_root" sequence="100"/>
+    <menuitem name="Build Statistics" id="runbot_menu_stat_tree" parent="runbot_menu_stat_root" sequence="10" action="open_view_stat_sql_tree"/>
+    <menuitem name="Stats Regexes" id="runbot_menu_manage_stat_regexes" parent="runbot_menu_stat_root" sequence="20" action="open_view_stat_regex_tree"/>
+    <menuitem name="Stat Regex Wizard" id="runbot_menu_stat_regex_wizard" parent="runbot_menu_stat_root" sequence="150" action="runbot_stat_regex_wizard_action"/>
+
+    <menuitem name="Warnings" id="runbot_menu_warning_root" parent="runbot_menu_root" sequence="110" action="open_view_warning_tree"/>
+
+    <menuitem name="Technical" id="runbot_menu_technical" parent="runbot_menu_root" sequence="1000"/>
+    <menuitem id="runbot_menu_ir_cron_act" action="base.ir_cron_act" parent="runbot_menu_technical"/>
+    <menuitem id="runbot_menu_base_automation_act" action="base_automation.base_automation_act" parent="runbot_menu_technical"/>
+    <menuitem id="runbot_menu_action_ui_view" action="base.action_ui_view" parent="runbot_menu_technical"/>
+
+    <menuitem name="▶" id="runbot_menu_website" parent="runbot_menu_root" sequence="1001" action="website.action_website"/>
+
+</odoo>
diff --git a/runbot/views/repo_views.xml b/runbot/views/repo_views.xml
index efac1996..117f5c3f 100644
--- a/runbot/views/repo_views.xml
+++ b/runbot/views/repo_views.xml
@@ -171,49 +171,5 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem id="runbot_menu_repos_main" name="Repos" parent="runbot_menu_root"/>
-    <menuitem
-       id="runbot_menu_repos"
-        parent="runbot_menu_repos_main"
-        sequence="10"
-        action="runbot_repos_action"
-        />
-      <menuitem
-        id="runbot_menu_remotes"
-        parent="runbot_menu_repos_main"
-        sequence="20"
-        action="runbot_remotes_action"
-      />
-      <menuitem
-        id="runbot_menu_trigger"
-        parent="runbot_menu_repos_main"
-        sequence="30"
-        action="runbot_triggers_action"
-      />
-      <menuitem
-        id="runbot_menu_trigger_category"
-        parent="runbot_menu_repos_main"
-        sequence="40"
-        action="runbot_triggers_category_action"
-      />
-
-      <menuitem
-        name="Technical"
-        id="runbot_menu_technical"
-        parent="runbot_menu_root"
-        sequence="1000"
-        />
-
-        <menuitem id="runbot_menu_ir_cron_act" action="base.ir_cron_act" parent="runbot_menu_technical"/>
-        <menuitem id="runbot_menu_base_automation_act" action="base_automation.base_automation_act" parent="runbot_menu_technical"/>
-        <menuitem id="runbot_menu_action_ui_view" action="base.action_ui_view" parent="runbot_menu_technical"/>
-
-      <menuitem
-        name="▶"
-        id="runbot_menu_website"
-        parent="runbot_menu_root"
-        sequence="1001"
-        action="website.action_website"
-        />
   </data>
 </odoo>
\ No newline at end of file
diff --git a/runbot/views/res_config_settings_views.xml b/runbot/views/res_config_settings_views.xml
index 7f42bf28..d2d88422 100644
--- a/runbot/views/res_config_settings_views.xml
+++ b/runbot/views/res_config_settings_views.xml
@@ -87,7 +87,6 @@
             <field name="context">{'module' : 'runbot'}</field>
         </record>
 
-        <menuitem id="menu_runbot_global_settings" name="Settings"
-            parent="runbot_menu_root" sequence="0" action="action_runbot_configuration" groups="base.group_system"/>
+
     </data>
 </odoo>
diff --git a/runbot/views/stat_views.xml b/runbot/views/stat_views.xml
index dba64bf6..5635296c 100644
--- a/runbot/views/stat_views.xml
+++ b/runbot/views/stat_views.xml
@@ -24,37 +24,22 @@
         <field name="view_mode">tree,graph,pivot</field>
     </record>
 
-    <menuitem
-        name="Build Statistics"
-        id="runbot_menu_stat_root"
-        parent="runbot_menu_root"
-        sequence="100"
-        />
-
-    <menuitem
-        name="Build Statistics"
-        id="runbot_menu_stat_tree"
-        parent="runbot_menu_stat_root"
-        sequence="10"
-        action="open_view_stat_sql_tree"
-        />
-
-      <record id="build_stat_regex_form" model="ir.ui.view">
-          <field name="name">runbot.build.stat.regex.form</field>
-          <field name="model">runbot.build.stat.regex</field>
-          <field name="arch" type="xml">
-            <form>
-              <sheet>
-                <group name="stat_regex_group">
-                  <field name="name"/>
-                  <field name="regex" placeholder="odoo.addons.(?P&lt;key&gt;.+) tested in .+, (?P&lt;value&gt;\d+) queries"/>
-                  <field name="generic"/>
-                  <field name="description"/>
-                </group>
-              </sheet>
-            </form>
-          </field>
-      </record>
+    <record id="build_stat_regex_form" model="ir.ui.view">
+        <field name="name">runbot.build.stat.regex.form</field>
+        <field name="model">runbot.build.stat.regex</field>
+        <field name="arch" type="xml">
+          <form>
+            <sheet>
+              <group name="stat_regex_group">
+                <field name="name"/>
+                <field name="regex" placeholder="odoo.addons.(?P&lt;key&gt;.+) tested in .+, (?P&lt;value&gt;\d+) queries"/>
+                <field name="generic"/>
+                <field name="description"/>
+              </group>
+            </sheet>
+          </form>
+        </field>
+    </record>
 
     <record id="build_stat_regex_tree" model="ir.ui.view">
         <field name="name">runbot.build.stat.regex.tree</field>
@@ -75,12 +60,5 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem
-        name="Stats Regexes"
-        id="runbot_menu_manage_stat_regexes"
-        parent="runbot_menu_stat_root"
-        sequence="20"
-        action="open_view_stat_regex_tree"
-    />
   </data>
 </odoo>
diff --git a/runbot/views/upgrade.xml b/runbot/views/upgrade.xml
index c5b7173d..6bfb31d1 100644
--- a/runbot/views/upgrade.xml
+++ b/runbot/views/upgrade.xml
@@ -60,19 +60,5 @@
         <field name="view_mode">tree,form</field>
     </record>
 
-    <menuitem
-        name="Upgrade Exceptions"
-        id="runbot_menu_upgrade_exceptions_tree"
-        parent="runbot_menu_configs"
-        sequence="30"
-        action="open_view_upgrade_exception_tree"
-        />
-    <menuitem
-        name="Upgrade Regexes"
-        id="runbot_menu_upgrade_regex_tree"
-        parent="runbot_menu_configs"
-        sequence="30"
-        action="open_view_upgrade_regex_tree"
-        />
   </data>
 </odoo>
diff --git a/runbot/views/warning_views.xml b/runbot/views/warning_views.xml
index 2a983d76..db956caf 100644
--- a/runbot/views/warning_views.xml
+++ b/runbot/views/warning_views.xml
@@ -18,13 +18,5 @@
       <field name="view_mode">tree</field>
     </record>
 
-    <menuitem
-        name="Warnings"
-        id="runbot_menu_warning_root"
-        parent="runbot_menu_root"
-        sequence="110"
-        action="open_view_warning_tree"
-        />
-
   </data>
 </odoo>
diff --git a/runbot/wizards/stat_regex_wizard_views.xml b/runbot/wizards/stat_regex_wizard_views.xml
index 1400b8ff..d52cfd67 100644
--- a/runbot/wizards/stat_regex_wizard_views.xml
+++ b/runbot/wizards/stat_regex_wizard_views.xml
@@ -35,12 +35,5 @@
             <field name="target">new</field>
         </record>
 
-        <menuitem
-            name="Stat Regex Wizard"
-            id="runbot_menu_stat_regex_wizard"
-            parent="runbot_menu_stat_root"
-            sequence="150"
-            action="runbot_stat_regex_wizard_action"
-            />
-  </data>
+    </data>
 </odoo>