From cc388715bc38be94f7d351ffca424cabea70898d Mon Sep 17 00:00:00 2001
From: Christophe Monniez <moc@odoo.com>
Date: Tue, 3 Sep 2019 15:02:21 +0200
Subject: [PATCH] [FIX] runbot: properly compute children_build_ids

The Many2many related on a Many2many does not map the ids as expected.
With this commit, the records are mapped in a compute.

It also fixes an uppercase letter was used in the children_build_ids field name.
---
 runbot/models/build_error.py       | 9 +++++++--
 runbot/views/build_error_views.xml | 4 ++--
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/runbot/models/build_error.py b/runbot/models/build_error.py
index 4ab192b0..62f8d5e8 100644
--- a/runbot/models/build_error.py
+++ b/runbot/models/build_error.py
@@ -32,7 +32,7 @@ class RunbotBuildError(models.Model):
     build_count = fields.Integer(compute='_compute_build_counts', string='Nb seen', stored=True)
     parent_id = fields.Many2one('runbot.build.error', 'Linked to')
     child_ids = fields.One2many('runbot.build.error', 'parent_id', string='Child Errors')
-    Children_build_ids = fields.Many2many(related='child_ids.build_ids', string='Children builds')
+    children_build_ids = fields.Many2many('runbot.build', compute='_compute_children_build_ids', string='Children builds')
 
     @api.model
     def create(self, vals):
@@ -47,7 +47,7 @@ class RunbotBuildError(models.Model):
     @api.depends('build_ids')
     def _compute_build_counts(self):
         for build_error in self:
-            build_error.build_count = len(build_error.build_ids) + len(build_error.Children_build_ids)
+            build_error.build_count = len(build_error.build_ids) + len(build_error.children_build_ids)
 
     @api.depends('build_ids')
     def _compute_branch_ids(self):
@@ -64,6 +64,11 @@ class RunbotBuildError(models.Model):
         for build_error in self:
             build_error.summary = build_error.content[:50]
 
+    @api.depends('child_ids')
+    def _compute_children_build_ids(self):
+        for build_error in self:
+            build_error.children_build_ids = build_error.mapped('child_ids.build_ids')
+
     @api.model
     def _digest(self, s):
         """
diff --git a/runbot/views/build_error_views.xml b/runbot/views/build_error_views.xml
index 5c7ddca4..761ee613 100644
--- a/runbot/views/build_error_views.xml
+++ b/runbot/views/build_error_views.xml
@@ -33,8 +33,8 @@
                   <field name="build_url" widget="url" readonly="1" text="View build"/>
                 </tree>
               </field>
-              <label for="Children_build_ids" string="Linked errors builds"/>
-              <field name="Children_build_ids" widget="many2many" options="{'not_delete': True, 'no_create': True}">
+              <label for="children_build_ids" string="Linked errors builds"/>
+              <field name="children_build_ids" widget="many2many" options="{'not_delete': True, 'no_create': True}">
                 <tree>
                   <field name="create_date"/>
                   <field name="id"/>