NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-15 15:35:46 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[FIX] runbot: only push if build was successfull

Browse Source
This commit is contained in:
Xavier-Do 2024-09-19 08:53:35 +02:00
parent 0b5d7d0566
commit da1e4e78ca
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
runbot/models/docker.py
View File

@ -323,11 +323,12 @@ class Dockerfile(models.Model):
should_save_result = True
if should_save_result:
result = self.env['runbot.docker_build_result'].create(docker_build_result_values)
build_result = self.env['runbot.docker_build_result'].create(docker_build_result_values)
if not success:
message = f'Build failure, check results for more info ({result.summary})'
message = f'Build failure, check results for more info ({build_result.summary})'
self.message_post(body=message)
_logger.error(message)
return result
class DockerBuildOutput(models.Model):

4
runbot/models/host.py
View File

@ -143,8 +143,8 @@ class Host(models.Model):
else:
_logger.info('Building docker images...')
for dockerfile in self.env['runbot.dockerfile'].search([('to_build', '=', True)]):
dockerfile._build(self)
if is_registry:
result = dockerfile._build(self)
if result.get('image_id') and is_registry:
docker_push(dockerfile.image_tag)
_logger.info('Cleaning docker images...')