From e01ad86171462534e63bb0cc5653621089c37bbb Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Wed, 12 Dec 2018 15:28:38 +0100 Subject: [PATCH] [IMP] runbot_merge: make feedback more deterministic Before this change, the order of PRs to list in an "unready" feedback message was whatever the DB returned which could vary. This change fixes the order by applying model order. --- runbot_merge/models/pull_requests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runbot_merge/models/pull_requests.py b/runbot_merge/models/pull_requests.py index 8640901b..30abe24e 100644 --- a/runbot_merge/models/pull_requests.py +++ b/runbot_merge/models/pull_requests.py @@ -763,7 +763,7 @@ class PullRequests(models.Model): for [ids] in self.env.cr.fetchall(): prs = self.browse(ids) ready = prs.filtered(lambda p: p.state == 'ready') - unready = prs - ready + unready = (prs - ready).sorted() for r in ready: self.env['runbot_merge.pull_requests.feedback'].create({