From e19a9fad8f78c9ab93b5a230ac7726bca3fe0c82 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Tue, 18 Feb 2025 11:41:03 +0100 Subject: [PATCH] [REM] forwardport: re-enablement of forward ports when closing wizard This can yield odd effects when playing around e.g. opening freeze wizards then cancelling them. There is a check that there are no wizards left, but if a freeze is performed then an other is created and cancelled it will immediately re-enable forward ports, unexpectedly. --- forwardport/models/project_freeze.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/forwardport/models/project_freeze.py b/forwardport/models/project_freeze.py index 0796fbaf..03a0d626 100644 --- a/forwardport/models/project_freeze.py +++ b/forwardport/models/project_freeze.py @@ -14,15 +14,3 @@ class FreezeWizard(models.Model): r = super().create(vals_list) self.env.ref('forwardport.port_forward').active = False return r - - def action_freeze(self): - return super(FreezeWizard, self.with_context(forwardport_keep_disabled=True))\ - .action_freeze() - - def unlink(self): - r = super().unlink() - if not (self.env.context.get('forwardport_keep_disabled') or self.search_count([])): - cron = self.env.ref('forwardport.port_forward') - cron.active = True - cron._trigger() # process forward ports enqueued during the freeze period - return r