From f378689a0db48a69554af86152ea66c17b9748d4 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@odoo.com>
Date: Fri, 9 Aug 2024 10:09:20 +0200
Subject: [PATCH] [FIX] runbot_merge: dumbshit 16.0 view validation complaints

---
 runbot_merge/views/batch.xml                |  6 +++---
 runbot_merge/views/mergebot.xml             | 24 ++++++++++-----------
 runbot_merge/views/runbot_merge_project.xml |  4 ++--
 3 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/runbot_merge/views/batch.xml b/runbot_merge/views/batch.xml
index ed3f04ba..0a62c0cf 100644
--- a/runbot_merge/views/batch.xml
+++ b/runbot_merge/views/batch.xml
@@ -59,7 +59,7 @@
                         <group colspan="4">
                             <field name="all_prs" nolabel="1" readonly="1">
                                 <tree>
-                                    <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                                    <button type="object" name="get_formview_action" icon="fa-external-link" title="open PR"/>
                                     <field name="display_name"/>
                                     <field name="repository"/>
                                     <field name="state"/>
@@ -71,7 +71,7 @@
                         <group colspan="4">
                             <field name="genealogy_ids" nolabel="1" readonly="1">
                                 <tree decoration-muted="id == parent.id">
-                                    <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                                    <button type="object" name="get_formview_action" icon="fa-external-link" title="open batch"/>
                                     <field name="name"/>
                                     <field name="target"/>
                                     <field name="all_prs" widget="many2many_tags"/>
@@ -83,7 +83,7 @@
                         <group colspan="4">
                             <field name="staging_ids" nolabel="1" readonly="1">
                                 <tree>
-                                    <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                                    <button type="object" name="get_formview_action" icon="fa-external-link" title="open staging"/>
                                     <field name="staged_at"/>
                                     <field name="state"/>
                                     <field name="reason"/>
diff --git a/runbot_merge/views/mergebot.xml b/runbot_merge/views/mergebot.xml
index 66888469..2b13e6eb 100644
--- a/runbot_merge/views/mergebot.xml
+++ b/runbot_merge/views/mergebot.xml
@@ -20,7 +20,7 @@
                     <separator string="Required Statuses"/>
                     <field name="status_ids">
                         <tree editable="bottom">
-                            <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                            <button type="object" name="get_formview_action" icon="fa-external-link" title="open status"/>
                             <field name="context"/>
                             <field name="branch_filter"/>
                             <field name="prs"/>
@@ -56,7 +56,7 @@
                     </group>
                     <field name="staging_ids" nolabel="1" readonly="1">
                         <tree default_order="staged_at desc">
-                            <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                            <button type="object" name="get_formview_action" icon="fa-external-link" title="open staging"/>
                             <field name="id"/>
                             <field name="staged_at"/>
                             <field name="state"/>
@@ -202,7 +202,7 @@
                                 <group colspan="4">
                                     <field name="delegates" nolabel="1">
                                         <tree>
-                                            <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                                            <button type="object" name="get_formview_action" icon="fa-external-link" title="open partner"/>
                                             <field name="name"/>
                                             <field name="github_login"/>
                                         </tree>
@@ -215,7 +215,7 @@
                                 <group colspan="4">
                                     <field name="staging_ids" nolabel="1" readonly="1">
                                         <tree>
-                                            <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                                            <button type="object" name="get_formview_action" icon="fa-external-link" title="open staging"/>
                                             <field name="staged_at"/>
                                             <field name="state"/>
                                             <field name="reason"/>
@@ -239,7 +239,7 @@
                               <group colspan="4">
                                 <field name="forwardport_ids" nolabel="1" readonly="True">
                                   <tree>
-                                    <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                                    <button type="object" name="get_formview_action" icon="fa-external-link" title="open PR"/>
                                     <field name="target" string="Branch"/>
                                     <field name="number"/>
                                   </tree>
@@ -337,7 +337,7 @@
                         <group string="Heads">
                             <field name="head_ids" colspan="2" nolabel="1" readonly="1">
                                 <tree>
-                                    <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                                    <button type="object" name="get_formview_action" icon="fa-external-link" title="open head"/>
                                     <field name="sha"/>
                                 </tree>
                             </field>
@@ -345,7 +345,7 @@
                         <group string="Commits">
                             <field name="commit_ids" colspan="2" nolabel="1" readonly="1">
                                 <tree>
-                                    <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                                    <button type="object" name="get_formview_action" icon="fa-external-link" title="open commit"/>
                                     <field name="sha"/>
                                 </tree>
                             </field>
@@ -354,7 +354,7 @@
                     <group string="Batches">
                         <field name="batch_ids" colspan="4" nolabel="1" readonly="1">
                             <tree>
-                                <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                                <button type="object" name="get_formview_action" icon="fa-external-link" title="open batch"/>
                                 <field name="name"/>
                                 <field name="prs" widget="many2many_tags"/>
                             </tree>
@@ -363,7 +363,7 @@
                     <group string="PRs">
                         <field name="pr_ids" colspan="4" nolabel="1" readonly="1">
                             <tree>
-                                <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                                <button type="object" name="get_formview_action" icon="fa-external-link" title="open pr"/>
                                 <field name="display_name"/>
                                 <field name="github_url" widget="url"/>
                                 <field name="url" widget="url"/>
@@ -402,7 +402,7 @@
                     <separator string="Pull Requests"/>
                     <field name="pull_requests" nolabel="1">
                         <tree>
-                            <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                            <button type="object" name="get_formview_action" icon="fa-external-link" title="open pr"/>
                             <field name="display_name"/>
                             <field name="state"/>
                         </tree>
@@ -410,7 +410,7 @@
                     <separator string="Stagings (commits)"/>
                     <field name="commit_ids" nolabel="1" readonly="1">
                         <tree>
-                            <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                            <button type="object" name="get_formview_action" icon="fa-external-link" title="open commit"/>
                             <field name="target"/>
                             <field name="id"/>
                             <field name="staged_at"/>
@@ -420,7 +420,7 @@
                     <separator string="Stagings (heads)"/>
                     <field name="head_ids" nolabel="1" readonly="1">
                         <tree>
-                            <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                            <button type="object" name="get_formview_action" icon="fa-external-link" title="open head"/>
                             <field name="target"/>
                             <field name="id"/>
                             <field name="staged_at"/>
diff --git a/runbot_merge/views/runbot_merge_project.xml b/runbot_merge/views/runbot_merge_project.xml
index 6e83376f..626cef9b 100644
--- a/runbot_merge/views/runbot_merge_project.xml
+++ b/runbot_merge/views/runbot_merge_project.xml
@@ -62,7 +62,7 @@
                     <field name="repo_ids">
                         <tree>
                             <field name="sequence" widget="handle"/>
-                            <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                            <button type="object" name="get_formview_action" icon="fa-external-link" title="open repo"/>
                             <field name="name"/>
                             <field name="branch_filter"/>
                             <field name="status_ids" widget="many2many_tags"/>
@@ -72,7 +72,7 @@
                     <field name="branch_ids">
                         <tree editable="bottom" decoration-muted="not active">
                             <field name="sequence" widget="handle" />
-                            <button type="object" name="get_formview_action" icon="fa-external-link"/>
+                            <button type="object" name="get_formview_action" icon="fa-external-link" title="open branch"/>
                             <field name="name"/>
                             <field name="active" widget="boolean_toggle"/>
                             <field name="staging_enabled" widget="boolean_toggle"/>