NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-27 13:25:47 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[CHG] runbot_merge: deskill mergebot feedback

Browse Source 
twas heehee in the moment but it's not really a long term hoohoo
haahaa.
This commit is contained in:
Xavier Morel 2024-08-05 09:09:23 +02:00
parent ec01523875
commit ff6f046811
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
runbot_merge/models/commands.py
View File

@ -269,7 +269,7 @@ class Parser:
if handler: if handler:
yield handler(self) yield handler(self)
elif '!' in token: elif '!' in token:
raise CommandError("skill issue, noob") raise CommandError("no need to scream")
else: else:
raise CommandError(f"unknown command {token!r}") raise CommandError(f"unknown command {token!r}")

2
runbot_merge/models/pull_requests.py
View File

@ -947,7 +947,7 @@ For your own safety I've ignored *everything in your entire comment*.
msg = "you can't set a forward-port limit." msg = "you can't set a forward-port limit."
# NO! # NO!
case _: case _:
msg = f"you can't {command}. Skill issue." msg = f"you can't {command}."
if msg is not None: if msg is not None:
rejections.append(msg) rejections.append(msg)

2
runbot_merge/tests/test_basic.py
View File

@ -3158,7 +3158,7 @@ class TestReviewing:
assert prx.comments == [ assert prx.comments == [
(users['reviewer'], 'hansen r+'), (users['reviewer'], 'hansen r+'),
seen(env, prx, users), seen(env, prx, users),
(users['user'], "@{} you can't review+. Skill issue.".format(users['reviewer'])), (users['user'], "@{} you can't review+.".format(users['reviewer'])),
] ]
def test_self_review_success(self, env, repo, users, config): def test_self_review_success(self, env, repo, users, config):