runbot/runbot_merge/changelog/2022-06
Xavier Morel 3da1874196 [FIX] runbot_merge: correctly handle emptying PR body
The previous version of the code assumed `pr['body']` is always a
string, which is not correct, when the PR body is emptied the body
itself is removed (its value is `None`).

Add a case for this in the PR edition test, and avoid blowing up (or
adding empty newlines) when the PR body is empty. For PR creation this
issue was fixed in c2db5659d8 but
apparently I missed that the exact same issue occurs just a few lines
above.

Also turns out github does *not* send change information when the body
is updated from (or to?) `None`, so don't even bother with that, just
check every time if the overall message has been updated.

Fixes #629
2022-08-05 15:35:51 +02:00
..
alerts.md [FIX] runbot_merge: also show banners on PR pages 2022-08-05 15:35:51 +02:00
empty-body.md [FIX] runbot_merge: correctly handle emptying PR body 2022-08-05 15:35:51 +02:00
pinging.md [IMP] *: review mergebot & forwardbot messages for pinging 2022-06-30 15:07:49 +02:00
provisioning.md [IMP] runbot_merge: provisioning features 2022-06-30 15:07:49 +02:00
ui.md [FIX] runbot_merge: also show banners on PR pages 2022-08-05 15:35:51 +02:00
unstaging.md [FIX] runbot_merge: unstage on staging-relevant PR modifications 2022-06-30 15:07:49 +02:00