mirror of
https://github.com/odoo/runbot.git
synced 2025-03-19 17:35:45 +07:00
391a323efd
Because the only condition between PRs and statuses is sharing a repository (and kinda not even that for stagings), adding or removing a status on a repository would try to recompute the statuses/state of essentially every staging in the history of the project, and a significant fraction of the PRs, leading to tens of thousands of queries, minutes of computation, and even OOMs of the HTTP workers as we'd load the PRs, their batches, and the stagings into memory to update them, then load more things because of what depends on PR statuses, etc... But there is no reason to touch any of the closed or merged PRs, or the completed (deactivated) stagings. And in fact there is every reason *not* to. Implementing a search-only m2m on each object in order to restrict the set of PRs/stagings relevant to a change reduces the number of queries to a few hundreds, the run time to seconds, and the memory increase to unnoticeable. The change still takes some time because the RD project currently has about 7000 open PRs, 4500 of which target odoo/odoo (which is our test case here), but that is nothing compared to the 164000 total PRs to odoo/odoo out of some 250000 PRs for the RD project. And though they're likely less of an issue as they don't recurse quite as much, the >120000 stagings during the project's history are not to be ignored, when then number of *active* stagings at any one time is at most the number of branches, which is half a dozen to a dozen. For very basic numbers, as of committing this change, creating a status in odoo/odoo (RD), optional on PRs and ignored on statuses, on my current machine (7530U with 32GB RAM): - without this change, 4835 queries, 37s of sql, 65s of non-SQL, RSS climbs to 2258128 (2.15GiB) - with this change, 758 queries, 1.46s SQL, 2.25s non-SQL, RSS climbs to 187088 (182MiB) Fixes #1067 |
||
|---|---|---|
| .. | ||
| backport | ||
| crons | ||
| ir_cron | ||
| project_freeze | ||
| staging_cancel | ||
| __init__.py | ||
| batch.py | ||
| commands.py | ||
| events_sources.py | ||
| ir_actions.py | ||
| ir_ui_view.py | ||
| mail_thread.py | ||
| patcher.py | ||
| project.py | ||
| pull_requests.py | ||
| res_partner.py | ||
| stagings_create.py | ||
| utils.py | ||