mirror of
https://github.com/odoo/runbot.git
synced 2025-03-15 23:45:44 +07:00
4bdf7e5eda
PRs transitioning to 'ready' had been checked and tested but turns out
I had completely forgotten to test that stagings would validate
properly therefore of course they didn't.
The issue here was I'd forgotten `''.split(',')` returns `['']` rather
than `[]`, so on an empty required_statuses the staging validator
would keep looking for a status matching the context `''` and would
never find it, keeping the staging pending until timeout. So most
likely the problem could have been resolved by just adding a condition
to
[r.strip() for r in repomap[c.sha].required_statuses.split(',')]
but I'd already done all the rest of the reorganisation by that point,
test pass and I think it's a somewhat better logic. Therefore I'll go
with that for now.
* properly handle empty required_statuses during staging validation
* remove the final postcondition, if we're missing commits which don't
require any statuse we should not care
* expand test to include up to merging PRs
* automatically create dummy commits when creating stagings, that way
the relevant commits are in the database (can't hurt)
PS: an other alternative would have been to filter out or skip ahead
on commits which don't require any statuses aka cmap &
required_statuse / cmap would not even have that entry
|
||
|---|---|---|
| forwardport | ||
| runbot | ||
| runbot_builder | ||
| runbot_cla | ||
| runbot_merge | ||
| .gitignore | ||
| conftest.py | ||
| README.md | ||
| requirements.txt | ||
Odoo Runbot Repository
This repository contains the source code of Odoo testing bot runbot.odoo.com and related addons.
Runbot
The runbot/ directory holds the main runbot Odoo addon.
Runbot CLA addon
The runbot_cla/ directory contains an Odoo addon that checks CLA.