mirror of
https://github.com/odoo/runbot.git
synced 2025-03-27 21:35:45 +07:00
9684c2d97e
Docker container names are derived from the dest and step name. The dest is itself derived from the branch name. In some rare cases, it happens that a character not allowed by Docker appears in the container name computed by the runbot. With this commit, a sanitize_container_name function is used to remove unallowed characters at the container utility level.
64 lines
2.3 KiB
Python
64 lines
2.3 KiB
Python
# -*- coding: utf-8 -*-
|
|
from odoo.tests import common
|
|
from ..container import Command
|
|
from ..container import sanitize_container_name
|
|
|
|
|
|
CONFIG = """[options]
|
|
foo = bar
|
|
"""
|
|
|
|
|
|
class Test_Command(common.TransactionCase):
|
|
|
|
def test_command(self):
|
|
pres = ['pip3', 'install', 'foo']
|
|
posts = ['python3', '-m', 'coverage', 'html']
|
|
finals = ['pgdump bar']
|
|
cmd = Command([pres], ['python3', 'odoo-bin'], [posts], finals=[finals])
|
|
self.assertEqual(str(cmd), 'python3 odoo-bin')
|
|
|
|
expected = 'pip3 install foo && python3 odoo-bin && python3 -m coverage html ; pgdump bar'
|
|
self.assertEqual(cmd.build(), expected)
|
|
|
|
cmd = Command([pres], ['python3', 'odoo-bin'], [posts])
|
|
cmd.add_config_tuple('a', 'b')
|
|
cmd += ['bar']
|
|
self.assertIn('bar', cmd.cmd)
|
|
cmd.add_config_tuple('x', 'y')
|
|
|
|
content = cmd.get_config(starting_config=CONFIG)
|
|
|
|
self.assertIn('[options]', content)
|
|
self.assertIn('foo = bar', content)
|
|
self.assertIn('a = b', content)
|
|
self.assertIn('x = y', content)
|
|
|
|
with self.assertRaises(AssertionError):
|
|
cmd.add_config_tuple('http-interface', '127.0.0.1')
|
|
|
|
|
|
class TestSanitizeContainerName(common.TransactionCase):
|
|
|
|
def test_sanitize_container_name(self):
|
|
|
|
# 1. test that a valid name remains unchanged
|
|
valid_name = '3155889-saas-13.4-container-all_at_install'
|
|
self.assertEqual(sanitize_container_name(valid_name), valid_name)
|
|
|
|
# 2. test a name starting with an invalid character
|
|
invalid_name = '#3155889-saas-13.4-container-all_at_install'
|
|
self.assertEqual(sanitize_container_name(invalid_name), valid_name)
|
|
|
|
# 3. test a name with an invalid character somewhere
|
|
invalid_name = '3155889-saas-13.4-container#-all_at_install'
|
|
self.assertEqual(sanitize_container_name(invalid_name), valid_name)
|
|
|
|
# 4. test a name starting with multiple invalid characters
|
|
invalid_name = '#/.3155889-saas-13.4-container-all_at_install'
|
|
self.assertEqual(sanitize_container_name(invalid_name), valid_name)
|
|
|
|
# 5. test both
|
|
invalid_name = '_.3155889-saas-13.4-##container/-all_at_install'
|
|
self.assertEqual(sanitize_container_name(invalid_name), valid_name)
|