mirror of
https://github.com/odoo/runbot.git
synced 2025-03-15 23:45:44 +07:00
728524db12
- Instead of warning about the merge method on ready PRs, also warn on *approved* (but exclude staged just cuz), as that's really when the user wants to know that they forgot to set the merge method - The cron only triggers hourly, but *if* a user approves a PR *and* the merge method is not set yet, chances are good they'll need a reminder (if they `r+ rebase-merge` or w/e the cron will just ignore the PR and it's no skin off our back), so `_trigger` the cron for validation. - Also do the same when skipchecks is set as it's very similar. In reality we might want to hook off of the state transitioning to reviewed but I'm not sure there's good ways to do that (triggering a cron inside a compute doesn't seem like a good idea). Update a pair of tests which would approve a multi-commit PR without setting a merge method, just because the helper they use to build the PR happens to create multiple commits. Fix #891 |
||
|---|---|---|
| .. | ||
| conftest.py | ||
| README.rst | ||
| test_basic.py | ||
| test_batch_consistency.py | ||
| test_by_branch.py | ||
| test_disabled_branch.py | ||
| test_multirepo.py | ||
| test_oddities.py | ||
| test_project_toggles.py | ||
| test_provisioning.py | ||
| test_staging.py | ||
| test_status_overrides.py | ||
Execute this test suite using pytest.
The default mode is to run tests locally using a mock github.com.
See the docstring of remote.py for instructions to run against github "actual"
(including remote-specific options) and the end of this file for a sample.
Shared properties running tests, regardless of the github implementation:
* test should be run from the root of the runbot repository providing the
name of this module aka ``pytest runbot_merge`` or
``python -mpytest runbot_merge``
* a database name to use must be provided using ``--db``, the database should
not exist beforehand
* the addons path must be specified using ``--addons-path``, both "runbot" and
the standard addons (odoo/addons) must be provided explicitly
See pytest's documentation for other options, I would recommend ``-rXs``,
``-v`` and ``--showlocals``.
When running "remote" tests as they take a very long time (hours) ``-x``
(aka ``--maxfail=1``) and ``--ff`` (run previously failed first) is also
recommended unless e.g. you run the tests overnight.
``pytest.ini`` sample
---------------------
.. code:: ini
[github]
owner = test-org
token = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
[role_reviewer]
name = Dick Bong
user = loginb
token = bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb
[role_self_reviewer]
name = Fanny Chmelar
user = loginc
token = cccccccccccccccccccccccccccccccccccccccc
[role_other]
name = Harry Baals
user = logind
token = dddddddddddddddddddddddddddddddddddddddd