mirror of
https://github.com/odoo/runbot.git
synced 2025-03-15 23:45:44 +07:00
![]() - Apparently if a user is on windows the ACE editor can swap out their line end from unix to windows. The patch parsers were predicated upon all patches being in unix mode (because git, and diff). Fixup both parsers to convert windows-style line end to unix before trying to parse the patch data. Also add a few fallbacks to limit the odds of an unhelpful `StopIteration` (though that might hide errors more than reveal them...) - Make sure we support `format-patch --no-signature`, just requires using the correct partition direction: I assume I used `rpartition` as a form of micro-optimisation *but* - If the separator is not found the "patch body" ends up in the third parameter rather than the first, which makes the fallback difficult. - There doesn't seem to be anything preventing *multiple* signature separators in a message, and logically the first one should hold and the rest is all part of the signature. As a result, for both reasons we need to look *forwards* for the signature separator, not backwards. Hence `str.partition`. Fixes #992 |
||
---|---|---|
.. | ||
backport | ||
crons | ||
project_freeze | ||
staging_cancel | ||
__init__.py | ||
batch.py | ||
commands.py | ||
events_sources.py | ||
ir_actions.py | ||
ir_ui_view.py | ||
mail_thread.py | ||
patcher.py | ||
project.py | ||
pull_requests.py | ||
res_partner.py | ||
stagings_create.py | ||
utils.py |