Xavier Morel 8abf1be278 [FIX] runbot_merge: cancel approval (r+) when fetching PRs ... When retrieving unknown PRs, the process would apply all comments, thereby applying eventual r+ without taking in account their relationship to a force push. This means it was possible for a mergebot-unknown PR to be r+'d, updated, retargeted, and the mergetbot would consider it good to go. The possible damage would be somewhat limited but still, not great. Sadly Github simply doesn't provide access to the entire event stream of the PR, so there is no way to even know whether the PR was updated, let alone when in relation to comments. Therefore just resync the PR after having applied comments: we still want to apply the merge method & al, we just want to reset back to un-approved. An other minor fix (for something we never actually hit but could): reviews are treated more or less as comments, but separate at github's level. The job would apply all comments then all reviews, so the relative order of comments and reviews would be wrong. Combine and order comments and reviews so they are applied in (hopefully) the correct order of their creation / submission. Closes #416		2020-11-20 07:41:54 +01:00
..
__init__.py	[ADD] runbot_merge: a merge bot	2018-09-03 13:16:36 +02:00
pull_requests.py	[FIX] runbot_merge: cancel approval (r+) when fetching PRs	2020-11-20 07:41:54 +01:00
res_partner.py	[FIX] runbot_merge: name_get using the wrong field on override rights	2020-11-20 07:41:54 +01:00