mirror of
https://github.com/odoo/runbot.git
synced 2025-03-15 23:45:44 +07:00
8e67aed792
When closing a PR, github completely separates the events "close the
PR" and "comment on the PR" (even when using "comment and close" in
the UI, a feature which isn't even available in the API). It doesn't
aggregate the notifications either, so users following the PR for
one reason or another get 2 notifications / mails every time a PR
gets merged, which is a lot of traffic, even more so with
forward-ported PRs multiplying the amount of PRs users are involved
in.
The comment on top of the closure itself is useful though: it allows
tracking exactly where and how the PR was merged from the PR, this
information should not be lost.
While more involved than a simple comment, *deployments* seem like
a suitable solution: they allow providing links as permanent
information / metadata on the PRs, and apparently don't trigger
notifications to users.
Therefore, modify the "close" method so it doesn't do
"comment-and-close", and provide a way to close PRs with non-comment
feedback: when the feedback's message is structured (parsable as
json) assume it's intended as deployment-bound notifications.
TODO: maybe add more keys to the feedback event payload, though in my
tests (odoo/runbot#222) none of the deployment metadata
outside of "environment" and "target_url" is listed on the PR
UI
Fixes #224
|
||
|---|---|---|
| forwardport | ||
| runbot | ||
| runbot_cla | ||
| runbot_merge | ||
| .gitignore | ||
| conftest.py | ||
| README.md | ||
Odoo Runbot Repository
This repository contains the source code of Odoo testing bot runbot.odoo.com and related addons.
Runbot
The runbot/ directory holds the main runbot Odoo addon.
Runbot CLA addon
The runbot_cla/ directory contains an Odoo addon that checks CLA.