runbot/runbot_merge/models
Xavier Morel c8a06601a7 [FIX] *: unstage on status going from success to failure
And unconditionally unstage when the HEAD of a PR is synchronised.

While a rebuild on a PR which was previously staged can be a false
positive (e.g. because it hit a non-derministic test the second time
around) it can also be legitimate e.g. auto-rebase of an old PR to
check it out. In that case the PR should be unstaged.

Furthermore, as soon as the PR gets rebuilt it goes back into
`approved` (because the status goes to pending and currently there's
no great way to suppress that in the rebuild case without also fucking
it up for the sync case). This would cause a sync on the PR to be
missed (in that it would not unstage the PR), which is broken. Fix
that by not checking the state of the PR beforehand, it seems to be an
unnecessary remnant of older code, and not really an optimisation (or
at least one likely not worth bothering with, especially as we then
proceed to perform a full PR validation anyway).

Fixes #950
2024-09-18 15:19:13 +02:00
..
crons [IMP] runbot_merge: prune repo during maintenance 2024-08-05 09:03:39 +02:00
project_freeze [FIX] *: ensure I don't get bollocked up again by tags 2024-09-06 15:09:08 +02:00
staging_cancel [ADD] runbot_merge: stagings canceling wizard 2022-12-08 10:46:22 +01:00
__init__.py [ADD] *: per-repository webhook secret 2024-06-06 11:07:57 +02:00
batch.py [IMP] runbot_merge: set status on skipchecks & use that 2024-09-16 12:49:23 +02:00
commands.py [FIX] *: UX around fw=no 2024-09-17 11:31:20 +02:00
events_sources.py [ADD] *: per-repository webhook secret 2024-06-06 11:07:57 +02:00
ir_actions.py [IMP] runbot_merge: add json & requests to server actions context 2023-02-20 10:13:05 +01:00
project.py [ADD] *: per-repository webhook secret 2024-06-06 11:07:57 +02:00
pull_requests.py [FIX] *: unstage on status going from success to failure 2024-09-18 15:19:13 +02:00
res_partner.py [ADD] runbot_merge: ad-hoc ACL tracking to res.partner 2024-05-16 09:32:03 +02:00
stagings_create.py [FIX] *: ensure I don't get bollocked up again by tags 2024-09-06 15:09:08 +02:00
utils.py [ADD] runbot_merge: rendering of PR descriptions 2024-07-15 10:28:28 +02:00