When running the test test_website_theme_preview, we have the following error:
`tour.steps has to be a function that returns TourStep[]`
runbot-111646
runbot-163139
closesodoo/design-themes#1069
X-original-commit: a3eb65d3ea
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The test was incorrectly flagging inner classes that follow our naming
convention (e.g. "s_floating_blocks_wrapper" for "s_floating_blocks"
snippet). This made maintaining the whitelist tedious and error prone.
The change enables proper enforcement of our conventions while
simplifying whitelist maintenance: a snippet subclass starting with "s_"
should be prefixed by the main snippet class name (e.g.
"s_super_snippet_item" might be added on an inner element of
"s_super_snippet"). The test just checks any element class is
prefixed by any class of any parent (or itself) (for "s_" classes).
Related to task-4373543
closesodoo/design-themes#1054
Related: odoo/odoo#189299
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This allows more flexibility on the use of `align-self-*-*` classes
combination to better handle responsiveness in some scenario.
Related to task-4373543
Part-of: odoo/design-themes#1054
Related: odoo/odoo#189299
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: theme_artists, theme_buzzy, theme_loftspace, theme_yes
The community "s_features" snippet for a specific new page template was
broken (missing all its classes). This commit adapts the related
themes overrides following the fix of that snippet (note that these
overrides were also broken by themselves).
Related to task-4373543
Part-of: odoo/design-themes#1054
Related: odoo/odoo#189299
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The snippet was switched to grid mode in this theme but the padding
classes on columns were not removed.
Related to task-4373543
Part-of: odoo/design-themes#1054
Related: odoo/odoo#189299
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: artists, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano,
notes, odoo_experts, orchid, paptic, real_estate, vehicle, yes
Steps to reproduce:
1. Enable a second language in the website (e.g., French).
2. Add a "Text" block (in edit mode) > Save the page.
3. Translate a text paragraph to french > Save.
4. In edit mode again, add a link to a word in the paragraph > Save.
5. The translation in French is lost, and sometimes the whole French
translation is used for the text before or after the link.
This is actually a limitation in the translation implementation. If we
initially have `text_1_en text_2_en text_3_en` translated to French this
way:
terms en_US: `["text_1_en text_2_en text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`
After adding a link: `text_1_en<a...>text_2_en</a>text_3_en`, and since
the links are not translated as a whole, we should get:
terms en_US: `["text_1_en", "text_2_en", "text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`
Which means the current translation will be lost, and the result will
depend on the outcome of `get_close_matches()`. Which explains why when
the link is added to the first words of the paragraph, the system still
maps the rest of the paragraph to its "full old translation".
The goal of this commit is to make this behavior less aggressive by
forcing the links added in paragraphs [1] to be translated as a whole.
This way, the `get_close_matches()` will map the new content with a link
to its old translation (without a link), and then, the user can set the
link in the "the most meaningful part of the translation" in the
translate mode.
[1]: We should use the "translate as a whole" feature carefully with
links, since there are already some situations where it's causing
issues (see the fix in [2]). So we only force them inside paragraphs.
[2]: https://github.com/odoo/odoo/commit/9bd60ca93510e410a0136b8b433f596330900593
Remark: This commit also sets the `o_translate_inline` class by default
on paragraph links in website templates.
opw-3984439
closesodoo/design-themes#1055
Related: odoo/odoo#204453
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>
*: theme_bewise, theme_cobalt, theme_kiddo, theme_loftspace,
theme_monglia, theme_nano, theme_notes, theme_odoo_experts,
theme_orchid, theme_paptic, theme_yes, theme_zap
Multiple snippet template where changed to ensure that the title is not
considered as a column and allowing changing the nb of columns again.
This commit adapts all the xpath that were impacted by those changes.
task-4310468
closesodoo/design-themes#1047
Related: odoo/odoo#195409
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The author field was made required by the previous commit, this commit
add the missing field in all manifests.
The upgrade-code script `18.2-01-manifest-author.py` was used. See
related community branch (same commit title).
task-4485983
closesodoo/design-themes#1044
Related: odoo/odoo#196408
Related: odoo/enterprise#78513
Related: odoo/documentation#11956
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
The `o_cc3` is rendering a white color depending on the the palette.
Using `o_cc5` ensure a white text on most palettes.
task-4381722
closesodoo/design-themes#1021
Signed-off-by: Christopher du Toit (chto) <chto@odoo.com>
*: artists, nano, notes, vehicle
This commit adapt the occurrences of the `s_form_aside` snippet across
themes.
task-4135499
part of task-4077427
closesodoo/design-themes#1007
Related: odoo/odoo#184094
Signed-off-by: Ivan Klapka (ivkl) <ivkl@odoo.com>
*: anelusia, artists, avantgarde, aviato, beauty, bewise, bistro,
bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace,
monglia, nano, notes, odoo_experts, orchid, paptic, real_estate,
treehouse, vehicle, yes, zap
This commit aims to fix a wrong implementation of gradients on the
`s_big_number` snippet within the context of the web editor.
Prior to this commit, the `s_big_number` snippet was using a gradient
composed of the right color, but being declared as `RGB` values.
While this is working as expected and looking like it uses the right
`--o-color-*`, it's indeed working with the specific color applied in
first place. If a user changes the color palette of the website, the
snippet will look terrible as it doesn't adapt to the new palette.
This commit fixes the issue by using the right implementation with CSS
variables.
It also reviews a wrong structure using `<div>` while it should use the
right html tag.
task-4202371
closesodoo/design-themes#930
Related: odoo/odoo#180983
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
theme_anelusia, theme_artists, theme_buzzy, theme_nano, theme_yes
This commit adapt the `s_timeline_images` snippet to the themes.
task-4105285
Part of task-4077427
closesodoo/design-themes#995
Related: odoo/odoo#184760
Signed-off-by: Ivan Klapka (ivkl) <ivkl@odoo.com>
Issue:
With PR [1], the url field for menus has been made required, with a
default value of #. This allows parent menus and megamenus to have a
URL.
However, in the theme_test_custo module, theme menus were previously
defined with parent menus having specific URLs. Due to this change, the
default url value is now #, making it impossible to search menus by URL.
As a result, the theme_menu_hierarchies tour failed.
Fix:
- Updated the menu search mechanism to align with the new behavior.
- Ensured that the tour passes successfully with the modified search
logic.
[1]: https://github.com/odoo/odoo/pull/160950closesodoo/design-themes#1042
Task: 3851453
Related: odoo/odoo#160950
Related: odoo/upgrade#5904
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
*: avantgarde, aviato, beauty, bewise, bistro,bookstore, buzzy, clean,
cobalt, kea, kiddo, monglia, nano, notes, Orchid, paptic, real_estate,
vehicle, yes, zap
This commit adapts the design of `s_company_team_card` for multiple
themes, based on the new Odoo 18 snippet redesign.
task-4149441
closesodoo/design-themes#902
Part-of: task-4077427
Related: odoo/odoo#179843
Signed-off-by: Christopher du Toit (chto) <chto@odoo.com>
*: theme_anelusia, theme_artists, theme_avantgarde, theme_aviato,
theme_beauty, theme_bistro, theme_enark, theme_kea, theme_loftspace,
theme_monglia, theme_nano, theme_notes, theme_orchid, theme_treehouse,
theme_vehicle, theme_yes, theme_zap
This commit adapts the themes to the new `s_comparisons_horizontal`
snippet.
task-4105264
Part of task-4077427
closesodoo/design-themes#992
Related: odoo/odoo#184281
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
With recent updates to the `s_opening_hours` snippet, an additional
xpath has become redundant in the context of this theme's revamp.
This commit removes the now unused xpath.
task-4207030
Part of task-4077427
closesodoo/design-themes#1004
Related: odoo/odoo#181170
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: artists, aviato, bistro, nano, notes
This commit adapts the design of `s_company_team_spotlight` for multiple themes,
based on the new Odoo 18 snippet redesign.
task-4147920
closesodoo/design-themes#903
Part-of: task-4077427
Related: odoo/odoo#179844
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit adds a line within the `new_page_templates` test in order to
allow the snippet `s_rating` to be used with `s_rating_no_title`.
task-4306631
closesodoo/design-themes#1041
Related: odoo/odoo#186130
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
See community commit for details
Note: this also fixes avantgarde svg/screenshot at the same time: we
remove the s_masonry_block but add the missing carousel.
(image contribution by MANO)
closesodoo/design-themes#1020
Related: odoo/odoo#183755
Related: odoo/upgrade#6642
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: mano-odoo <mano@odoo.com>
..cher
Defines dataset directly on website elements such that it can be
overridden by other modules if necessary.
This was done due to the override in the `test_themes` module completely
overriding all attributes of the website_switcher's dropdown items.
Runbot Error 106501
closesodoo/design-themes#1029
X-original-commit: c5f4e1c414
Related: odoo/odoo#190526
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>
*: artists, nano
This commit adapts the design of new `s_cta_mobile` snippet for
multiple themes.
Part of task-4077427
task-4094393
closesodoo/design-themes#1019
Related: odoo/odoo#185635
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The customization of that block was removing the parent container by
mistake, making the editor crash.
Related to task-4246355
X-original-commit: c97e39eee5
Part-of: odoo/design-themes#1023
Related: odoo/odoo#189669
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: anelusia, anelusia, enark, kiddo, loftspace, notes
- Install Website e-commerce.
- Select the "Kea" theme for your website.
- Go to the "/shop" page.
- Click on "Desks" category to go to the "/shop/category/desks-1" page.
- Click on edit to enter edit mode.
- Click on the "theme" tab.
- Change the website background color to "black".
- Bug: The breadcrumb has an ugly white background instead of no
background color, as in the "default" theme. Also, the "active"
breadcrumb item is hidden due to white text on a white background.
This commit removes the white background from the breadcrumb for all
themes that use it. This ensures the same appearance as other themes.
opw-4232082
closesodoo/design-themes#1018
X-original-commit: fe91239586
Signed-off-by: Serge Bayet (seba) <seba@odoo.com>
*: nano, notes, odoo_experts, treehouse, zap
This commit reviews the occurrences of the `s_numbers_*` snippets
to align them with the new layout of these snippets.
Prior to this commit, the layout of those snippet was "broken" due to
weird structure like nested rows, .. which prevents the editor to apply
a change on the whole content.
As we reworked the layout of these snippets to fix the issue, we need to
apply these changes in themes as well.
task-4223179
closesodoo/design-themes#1012
Related: odoo/odoo#185688
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: avantgarde, loftspace, real_estate, zap
This commit updates the images in the `s_striped_center_top` snippet for
specific themes. The previous images were not visually good due to their
height. The new, more landscape-oriented images provide a better visual
fit, improving the overall design and aesthetics across the themes.
task-4179589
Part of task-4077427
closesodoo/design-themes#904
Related: odoo/odoo#179888
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
In some theme customizations, some replaced images do not have the usual
image classes `img img-fluid mx-auto` anymore. The `img-fluid` one is
needed for grid images in mobile view, as they are overflowing without
it.
This commit adds these missing classes on the identified problematic
images.
closesodoo/design-themes#1003
X-original-commit: d5645edf28
Related: odoo/odoo#185715
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Hubert Van De Walle