Compare commits

...

1 Commits

Author SHA1 Message Date
Géry Debongnie cf02319c34 [REF] app: move app specific error handling code
It was before in the generic error handling file. However, since it is
there, it is not possible to modify this behaviour by subclassing App.
Another usecase would be for the devtools extension: with this commit,
it is now easily able to listen to app destruction events.
2023-03-16 15:33:59 +01:00
2 changed files with 11 additions and 7 deletions
+10
View File
@@ -213,6 +213,16 @@ export class App<
handleError(...args: Parameters<typeof handleError>) {
return handleError(...args);
}
onUnhandledError(error: Error) {
console.warn(`[Owl] Unhandled error. Destroying the root component`);
try {
this.destroy();
} catch (e) {
console.error(e);
}
throw error;
}
}
export async function mount<
+1 -7
View File
@@ -65,12 +65,6 @@ export function handleError(params: ErrorParams) {
const handled = _handleError(node, error);
if (!handled) {
console.warn(`[Owl] Unhandled error. Destroying the root component`);
try {
node.app.destroy();
} catch (e) {
console.error(e);
}
throw error;
node.app.onUnhandledError(error);
}
}