NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-15 23:45:44 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity
18.0
runbot/runbot_merge/views/res_partner.xml

102 lines
4.8 KiB
XML
Raw Permalink Normal View History

[ADD] runbot_merge: a merge bot No actual dependency on runbot, should be usable completely independently.
2018-03-14 16:37:46 +07:00
<odoo>
[MERGE] bot from 16.0 to 17.0 Broken (can't run odoo at all): - In Odoo 17.0, the `pre_init_hook` takes an env, not a cursor, update `_check_citext`. - Odoo 17.0 rejects `@attrs` and doesn't say where they are or how to update them, fun, hunt down `attrs={'invisible': ...` and try to fix them. - Odoo 17.0 warns on non-multi creates, update them, most were very reasonable, one very wasn't. Test failures: - Odoo 17.0 deprecates `name_get` and doesn't use it as a *source* anymore, replace overrides by overrides to `_compute_display_name`. - Multiple tracking changes: - `_track_set_author` takes a `Partner` not an id. - `_message_compute_author` still requires overriding in order to handle record creation, which in standard doesn't support author overriding. - `mail.tracking.value.field_type` has been removed, the field type now needs to be retrieved from the `field_id`. - Some tracking ordering have changed and require adjusting a few tests. Also added a few flushes before SQL queries which are not (obviously at least) at the start of a cron or controller, no test failure observed but better safe than sorry (probably).
2024-08-12 18:13:03 +07:00
<record id="runbot_merge_search_partner" model="ir.ui.view">
[IMP] runbot_merge: allow finding partners by github login Also remove search on ref which we don't use
2021-10-25 15:14:01 +07:00
<field name="name">Improve search on partners</field>
[FIX] runbot_merge: miswritten view file
2021-11-10 14:11:09 +07:00
<field name="model">res.partner</field>
[IMP] runbot_merge: allow finding partners by github login Also remove search on ref which we don't use
2021-10-25 15:14:01 +07:00
<field name="inherit_id" ref="base.view_res_partner_filter"/>
<field name="arch" type="xml">
<field name="name" position="attributes">
<attribute name="filter_domain">[
'|', '|',
('name', 'ilike', self),
('github_login', 'ilike', self),
('email', 'ilike', self),
]</attribute>
</field>
</field>
</record>
[IMP] runbot_merge: display & filtering of partners list * only provide fields which make sense for the mergebot * provide formatting & searchability for review rights records so they're visible from the list directly
2020-02-12 21:34:26 +07:00
<record id="runbot_merge_tree_partner" model="ir.ui.view">
<field name="name">Configure partners list to be useful</field>
<field name="model">res.partner</field>
<field name="inherit_id" ref="base.view_partner_tree"/>
<field name="arch" type="xml">
<xpath expr="//tree" position="replace">
<tree string="Contacts">
<field name="display_name" string="Name"/>
<field name="github_login"/>
<field name="review_rights" widget="many2many_tags"/>
[IMP] *: allow disabling staging on branch, remove fp target flag - currently disabling staging only works globally, allow disabling on a single branch - use a toggle - remove a pair of tests which work specifically with `fp_target`, can't work with `active` (probably) - cleanup search of possible and active stagings, add relevant indexes and use direct search of relevant branches instead of looking up from the project - also use toggle button for `active` on branches - shitty workaround for upgrading DB: apparently mail really wants to have a `user_id` to do some weird thing, so need to re-add it after resetting everything Fixes #727
2023-06-08 13:19:43 +07:00
<field name="user_id" invisible="1"/>
[IMP] runbot_merge: display & filtering of partners list * only provide fields which make sense for the mergebot * provide formatting & searchability for review rights records so they're visible from the list directly
2020-02-12 21:34:26 +07:00
</tree>
</xpath>
</field>
</record>
[ADD] runbot_merge: a merge bot No actual dependency on runbot, should be usable completely independently.
2018-03-14 16:37:46 +07:00
<record id="runbot_merge_form_partner" model="ir.ui.view">
<field name="name">Add mergebot/GH info to partners form</field>
<field name="model">res.partner</field>
<field name="inherit_id" ref="base.view_partner_form"/>
<field name="arch" type="xml">
[IMP] runbot_merge: reject review without email If a reviewer doesn't have an email set, the Signed-Off-By is an `@users.noreply.github.com` address which just looks weird in the final result. Initially the thinking was that emails would be required for users to *be* reviewers or self-reviewers, but since those are now o2ms / m2ms it's a bit of a pain in the ass. Instead, provide an action to easily try and fetch the public email of a user from github. Fixes #531
2021-10-06 18:06:53 +07:00
<xpath expr="//sheet" position="before">
[MERGE] bot from 15.0 to 16.0 Breakages: - the entire http.py API was updated requiring fixing the uses of `request.jsonrequest` and the patches to `WebRequest` to hook in sentry - `fontawesome` was moved - `*[@groups]` are now completely removed from the view if not matching, so any field inside of them which needs to be used outside (e.g. attrs) has to be added as invisible outside the element - discuss removed the mail tracking value helpers from RPC in odoo/odoo#88547, so reimplement locally (and better)
2024-08-07 19:14:27 +07:00
<field name="github_login" invisible="1"/>
<field name="review_rights" invisible="1"/>
[IMP] runbot_merge: reject review without email If a reviewer doesn't have an email set, the Signed-Off-By is an `@users.noreply.github.com` address which just looks weird in the final result. Initially the thinking was that emails would be required for users to *be* reviewers or self-reviewers, but since those are now o2ms / m2ms it's a bit of a pain in the ass. Instead, provide an action to easily try and fetch the public email of a user from github. Fixes #531
2021-10-06 18:06:53 +07:00
<header>
<button type="object" name="fetch_github_email"
string="Fetch Github Email" class="oe_highlight"
[MERGE] bot from 16.0 to 17.0 Broken (can't run odoo at all): - In Odoo 17.0, the `pre_init_hook` takes an env, not a cursor, update `_check_citext`. - Odoo 17.0 rejects `@attrs` and doesn't say where they are or how to update them, fun, hunt down `attrs={'invisible': ...` and try to fix them. - Odoo 17.0 warns on non-multi creates, update them, most were very reasonable, one very wasn't. Test failures: - Odoo 17.0 deprecates `name_get` and doesn't use it as a *source* anymore, replace overrides by overrides to `_compute_display_name`. - Multiple tracking changes: - `_track_set_author` takes a `Partner` not an id. - `_message_compute_author` still requires overriding in order to handle record creation, which in standard doesn't support author overriding. - `mail.tracking.value.field_type` has been removed, the field type now needs to be retrieved from the `field_id`. - Some tracking ordering have changed and require adjusting a few tests. Also added a few flushes before SQL queries which are not (obviously at least) at the start of a cron or controller, no test failure observed but better safe than sorry (probably).
2024-08-12 18:13:03 +07:00
invisible="email or not github_login"
[IMP] runbot_merge: reject review without email If a reviewer doesn't have an email set, the Signed-Off-By is an `@users.noreply.github.com` address which just looks weird in the final result. Initially the thinking was that emails would be required for users to *be* reviewers or self-reviewers, but since those are now o2ms / m2ms it's a bit of a pain in the ass. Instead, provide an action to easily try and fetch the public email of a user from github. Fixes #531
2021-10-06 18:06:53 +07:00
/>
</header>
[IMP] runbot_merge: add misconfiguration warning to partner view Following #531 reviews from reviewers without an email set are rejected. For delegates this isn't very helpful, however for specifically configured reviewers we can warn the configurer that they need to set an email for things to work out.
2021-10-25 14:07:38 +07:00
<div class="alert alert-warning" role="alert"
[MERGE] bot from 16.0 to 17.0 Broken (can't run odoo at all): - In Odoo 17.0, the `pre_init_hook` takes an env, not a cursor, update `_check_citext`. - Odoo 17.0 rejects `@attrs` and doesn't say where they are or how to update them, fun, hunt down `attrs={'invisible': ...` and try to fix them. - Odoo 17.0 warns on non-multi creates, update them, most were very reasonable, one very wasn't. Test failures: - Odoo 17.0 deprecates `name_get` and doesn't use it as a *source* anymore, replace overrides by overrides to `_compute_display_name`. - Multiple tracking changes: - `_track_set_author` takes a `Partner` not an id. - `_message_compute_author` still requires overriding in order to handle record creation, which in standard doesn't support author overriding. - `mail.tracking.value.field_type` has been removed, the field type now needs to be retrieved from the `field_id`. - Some tracking ordering have changed and require adjusting a few tests. Also added a few flushes before SQL queries which are not (obviously at least) at the start of a cron or controller, no test failure observed but better safe than sorry (probably).
2024-08-12 18:13:03 +07:00
invisible="email or not review_rights">
[IMP] runbot_merge: add misconfiguration warning to partner view Following #531 reviews from reviewers without an email set are rejected. For delegates this isn't very helpful, however for specifically configured reviewers we can warn the configurer that they need to set an email for things to work out.
2021-10-25 14:07:38 +07:00
Reviewers must have an email address set! Without an email
configured, reviews will be ignored.
</div>
[IMP] runbot_merge: reject review without email If a reviewer doesn't have an email set, the Signed-Off-By is an `@users.noreply.github.com` address which just looks weird in the final result. Initially the thinking was that emails would be required for users to *be* reviewers or self-reviewers, but since those are now o2ms / m2ms it's a bit of a pain in the ass. Instead, provide an action to easily try and fetch the public email of a user from github. Fixes #531
2021-10-06 18:06:53 +07:00
</xpath>
[ADD] runbot_merge: a merge bot No actual dependency on runbot, should be usable completely independently.
2018-03-14 16:37:46 +07:00
<xpath expr="//notebook" position="inside">
[IMP] runbot_merge: only show mergebot configuration to mergebot admins
2018-09-22 21:10:54 +07:00
<page string="Mergebot" groups="runbot_merge.group_admin">
[IMP] runbot_merge: view warnings around ACLs Eventually we might want to add a proper "sensitive" flag on overrides and compute the flag based on that. For now just check for `ci/security`.
2024-03-19 18:24:43 +07:00
<field name="override_sensitive" invisible="1"/>
[ADD] runbot_merge: a merge bot No actual dependency on runbot, should be usable completely independently.
2018-03-14 16:37:46 +07:00
<group>
<group>
<field name="github_login"/>
</group>
[IMP] runbot_merge: make review rights repo-dependent As the odds of having more projects or more repos with different requirements in the same project, the need to have different sets of reviewers for different repositories increases. As a result, rather than be trivial boolean flags the review info should probably depend on the user / partner and the repo. Turns out the permission checks had already been extracted into their own function so most of the mess comes from testing utilities which went and configured their review rights as needed. Incidentally it might be that the test suite could just use something like a sequence of commoditized accounts which get configured as needed and not even looked at unless they're used.
2020-02-10 21:05:08 +07:00
</group>
<group>
<group colspan="4" string="Review Rights">
[FIX] runbot_merge: layout backend issues galore - Odoo 17 seems to not be adjusting `nolabel` fields to be `colspan=2` by default, so every such occurrence has to be adjusted by hand or it gets squeezed in just the labels column. - Because of the loss of readonly mode, some fields / setups which previously looked ugly during the rare edition (e.g. Pr titles) now look ugly all the time. Rework layout and force them to always be readonly (hopefully we won't need to edit those). - This is compounded by unfortunate styling I can't find how to override e.g. char fields are 100% width even if readonly. - `<header>` system requires some workarounds to have the right layout and spacing (notably `header` has a bunch of awful rules which we need to work around via an interstitial div to set up our own flexbox).
2024-08-16 19:24:06 +07:00
<div colspan="2" class="alert alert-warning" role="alert" invisible="not review_rights">
[IMP] runbot_merge: view warnings around ACLs Eventually we might want to add a proper "sensitive" flag on overrides and compute the flag based on that. For now just check for `ci/security`.
2024-03-19 18:24:43 +07:00
Review access requires successfully following
the Code Review (QDP) and Security (DLE)
trainings. Please check before giving r+ access.
</div>
[FIX] runbot_merge: layout backend issues galore - Odoo 17 seems to not be adjusting `nolabel` fields to be `colspan=2` by default, so every such occurrence has to be adjusted by hand or it gets squeezed in just the labels column. - Because of the loss of readonly mode, some fields / setups which previously looked ugly during the rare edition (e.g. Pr titles) now look ugly all the time. Rework layout and force them to always be readonly (hopefully we won't need to edit those). - This is compounded by unfortunate styling I can't find how to override e.g. char fields are 100% width even if readonly. - `<header>` system requires some workarounds to have the right layout and spacing (notably `header` has a bunch of awful rules which we need to work around via an interstitial div to set up our own flexbox).
2024-08-16 19:24:06 +07:00
<field colspan="2" name="review_rights" nolabel="1">
[IMP] runbot_merge: make review rights repo-dependent As the odds of having more projects or more repos with different requirements in the same project, the need to have different sets of reviewers for different repositories increases. As a result, rather than be trivial boolean flags the review info should probably depend on the user / partner and the repo. Turns out the permission checks had already been extracted into their own function so most of the mess comes from testing utilities which went and configured their review rights as needed. Incidentally it might be that the test suite could just use something like a sequence of commoditized accounts which get configured as needed and not even looked at unless they're used.
2020-02-10 21:05:08 +07:00
<tree string="Review ACLs" editable="bottom">
<field name="repository_id"/>
<field name="review"/>
<field name="self_review"/>
</tree>
</field>
[ADD] runbot_merge: a merge bot No actual dependency on runbot, should be usable completely independently.
2018-03-14 16:37:46 +07:00
</group>
[FIX] runbot_merge: layout backend issues galore - Odoo 17 seems to not be adjusting `nolabel` fields to be `colspan=2` by default, so every such occurrence has to be adjusted by hand or it gets squeezed in just the labels column. - Because of the loss of readonly mode, some fields / setups which previously looked ugly during the rare edition (e.g. Pr titles) now look ugly all the time. Rework layout and force them to always be readonly (hopefully we won't need to edit those). - This is compounded by unfortunate styling I can't find how to override e.g. char fields are 100% width even if readonly. - `<header>` system requires some workarounds to have the right layout and spacing (notably `header` has a bunch of awful rules which we need to work around via an interstitial div to set up our own flexbox).
2024-08-16 19:24:06 +07:00
<group colspan="2">
<div colspan="2" class="alert alert-danger" role="alert" invisible="not override_sensitive">
[IMP] runbot_merge: view warnings around ACLs Eventually we might want to add a proper "sensitive" flag on overrides and compute the flag based on that. For now just check for `ci/security`.
2024-03-19 18:24:43 +07:00
Security Override <b>REQUIRES</b> successfully
following the Security training. Please ask DLE
before granting access.
</div>
[FIX] runbot_merge: layout backend issues galore - Odoo 17 seems to not be adjusting `nolabel` fields to be `colspan=2` by default, so every such occurrence has to be adjusted by hand or it gets squeezed in just the labels column. - Because of the loss of readonly mode, some fields / setups which previously looked ugly during the rare edition (e.g. Pr titles) now look ugly all the time. Rework layout and force them to always be readonly (hopefully we won't need to edit those). - This is compounded by unfortunate styling I can't find how to override e.g. char fields are 100% width even if readonly. - `<header>` system requires some workarounds to have the right layout and spacing (notably `header` has a bunch of awful rules which we need to work around via an interstitial div to set up our own flexbox).
2024-08-16 19:24:06 +07:00
<field colspan="2" name="override_rights" widget="many2many_tags"/>
[ADD] runbot_merge: allow overriding statuses Adds an `override` mergebot command. The ability to override is set on an individual per-context per-repository basis, similar to but independent from review rights. That is, a given individual may be able to override the status X on repository A and unable to do so on repository B. Overrides are stored in the same format as regular statuses, but independent from them in order to persist them across builds. Only PR statuses can be overridden, statuses which are overridable on PRs would simply not be required on stagings. An alternative to implementing this feature in the mergebot would be to add it to individual status-generating tools on a per-need basis. Pros of that alternative: * display the correct status on PRs, currently the PR will be failing status-wise (on github) but correct as far as the mergebot is concerned * remove complexity from the mergebot Cons of that alternative: * each status-generating tool would have to implement some sort of ACL system * each status-generating tool would have to receive & parse PR comments * each status-generating tool would have to maintain per-pr state in order to track overrides Some sort of helper library / framework ought make that rather easy though. It could also be linked into the central provisioning system thing. Closes #376
2020-07-14 15:06:07 +07:00
</group>
[ADD] runbot_merge: a merge bot No actual dependency on runbot, should be usable completely independently.
2018-03-14 16:37:46 +07:00
</group>
<group>
[FIX] runbot_merge: layout backend issues galore - Odoo 17 seems to not be adjusting `nolabel` fields to be `colspan=2` by default, so every such occurrence has to be adjusted by hand or it gets squeezed in just the labels column. - Because of the loss of readonly mode, some fields / setups which previously looked ugly during the rare edition (e.g. Pr titles) now look ugly all the time. Rework layout and force them to always be readonly (hopefully we won't need to edit those). - This is compounded by unfortunate styling I can't find how to override e.g. char fields are 100% width even if readonly. - `<header>` system requires some workarounds to have the right layout and spacing (notably `header` has a bunch of awful rules which we need to work around via an interstitial div to set up our own flexbox).
2024-08-16 19:24:06 +07:00
<group colspan="2" string="Delegate On">
<field name="delegate_reviewer" nolabel="1" colspan="2">
[IMP] runbot_merge: a few backend screens - override the staging's name_get to provide a slightly more useful display_name (though still not great as the staging object remains quite technical and inimical to human interaction) - show individual PRs in a batch (as m2m tags) for readability - update PR views to show the author and reviewer, except in the list of delegations of users where it's a lot less useful /cc #632
2022-07-29 18:43:40 +07:00
<tree>
<field name="repository"/>
<field name="number"/>
<field name="target"/>
<field name="state"/>
</tree>
</field>
[ADD] runbot_merge: a merge bot No actual dependency on runbot, should be usable completely independently.
2018-03-14 16:37:46 +07:00
</group>
</group>
</page>
</xpath>
</field>
</record>
</odoo>
Reference in New Issue Copy Permalink