NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-27 13:25:47 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[FIX] runbot_build_stats

Browse Source 
Since the order was changed, the first values are actually the older ones.
This commit inverse newer_build_stats and older_build_stats
values in order to always have the new keys. Before this commit the new
keys where not displayed. A future improvement may be to combine keys
from all builds.

This commit also proposes to give a 0 value if the key did not exist in
the older build. This means that new keys will appear with a big
difference. This is maybe not a good idea and needs some testing. A
better solution would be to search for the first apparition.
This commit is contained in:
Xavier-Do 2021-08-19 16:01:30 +02:00 committed by xdo
parent 874719870d
commit 2604d962e9
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
runbot/static/src/js/stats.js
View File

@ -81,12 +81,12 @@ function process_chart_data(){
return return
} }
var builds = Object.keys(config.result); var builds = Object.keys(config.result);
var newer_build_stats = config.result[builds[0]]; var newer_build_stats = config.result[builds.slice(-1)[0]];
var older_build_stats = config.result[builds.slice(-1)[0]]; var older_build_stats = config.result[builds[0]];
var mode = document.getElementById('mode_selector').value; var mode = document.getElementById('mode_selector').value;
var keys = Object.keys(newer_build_stats); var keys = Object.keys(newer_build_stats) ;
var sort_values = {} var sort_values = {}
for (key of keys) { for (key of keys) {
@ -107,9 +107,13 @@ function process_chart_data(){
previous = value previous = value
} }
} }
else if (older_build_stats[key] !== undefined) { else {
if (mode == "difference") { if (mode == "difference") {
sort_value = Math.abs(newer_build_stats[key] - older_build_stats[key]) var previous_value = 0;
if (older_build_stats[key] !== undefined) {
previous_value = older_build_stats[key]
}
sort_value = Math.abs(newer_build_stats[key] - previous_value)
} }
} }
sort_values[key] = sort_value sort_values[key] = sort_value
@ -127,9 +131,11 @@ function process_chart_data(){
return NaN; return NaN;
if (mode == 'normal' || mode == 'alpha') if (mode == 'normal' || mode == 'alpha')
return build_stats[key] return build_stats[key]
if (older_build_stats[key] === undefined) var previous_value = 0;
return NaN; if (older_build_stats[key] !== undefined) {
return build_stats[key] - older_build_stats[key] previous_value = older_build_stats[key]
}
return build_stats[key] - previous_value
} }
config.data = { config.data = {