NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-27 13:25:47 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[IMP] runbot_merge: don't quote signoff

Browse Source 
Proper RFC5322 makes for much noisier messages, and seems completely
unnecessary as examples of sign-off on the internet don't quote spaces
/ names.

closes #102
This commit is contained in:
Xavier Morel 2019-03-04 13:17:10 +01:00
parent 1f30af4345
commit 360d0e17ca
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
runbot_merge/models/res_partner.py
View File

@ -1,4 +1,4 @@
from email.utils import parseaddr, formataddr from email.utils import parseaddr
from odoo import fields, models, tools, api from odoo import fields, models, tools, api
class Partner(models.Model): class Partner(models.Model):
@ -16,9 +16,8 @@ class Partner(models.Model):
self._cr, 'runbot_merge_unique_gh_login', self._table, ['github_login']) self._cr, 'runbot_merge_unique_gh_login', self._table, ['github_login'])
return res return res
@api.multi @api.depends('name', 'email', 'github_login')
def _rfc5322_formatted(self): def _rfc5322_formatted(self):
# format partner's email according to RFC5322 section 3.4
for partner in self: for partner in self:
if partner.email: if partner.email:
email = parseaddr(partner.email)[1] email = parseaddr(partner.email)[1]
@ -26,4 +25,4 @@ class Partner(models.Model):
email = '%s@users.noreply.github.com' % partner.github_login email = '%s@users.noreply.github.com' % partner.github_login
else: else:
email = '' email = ''
partner.formatted_email = formataddr((partner.name, email)) partner.formatted_email = '%s <%s>' % (partner.name, email)