NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-15 15:35:46 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[IMP] runbot_merge: hide backend links from group_user

Browse Source 
The backend links in the PR dashboard were gated behind the
`group_user` (internal user) group, however turns out while internal
users have read access to PRs they don't have access to ancillary
objects (e.g. batches, stagings, the link between stagings and
batches), and I think the only way to fix the issue would be to move
it to an optional inheritance (inheritance + group), because `groups`
on view nodes only hides the content without removing it.

I believe in more recent Odoo versions this actually works correctly,
so that might actually be more of an incentive to upgrade...
This commit is contained in:
Xavier Morel 2024-06-20 14:21:40 +02:00
parent 20d259aa77
commit 4a521e1251
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
runbot_merge/views/templates.xml
View File

@ -430,7 +430,7 @@
</a>
<a t-attf-href="/web#view_type=form&amp;model=runbot_merge.pull_requests&amp;id={{pr.id}}"
class="btn btn-sm btn-secondary align-top float-right"
groups="base.group_user">View in backend</a>
groups="runbot_merge.group_admin">View in backend</a>
</h1>
<h6>Created by <span t-field="pr.author.display_name"/></h6>
<t t-set="tmpl">
@ -597,7 +597,7 @@ action = batches
title="Open on Github"
t-att-href="p['github_url']"
/>
<a groups="base.group_user"
<a groups="runbot_merge.group_admin"
title="Open in Backend"
t-attf-class="fa fa-external-link"
t-att-href="p['backend_url']"