mirror of
https://github.com/odoo/runbot.git
synced 2025-03-15 23:45:44 +07:00
[FIX] runbot: remove useless commit()
This commit() is the root cause of the famous false-positive error `_check_module_names invalid module names, ignored: False`. The first step (pull code) is a long one. if a push-hook request happen during this step, the current transaction wont be able to be commited (the list of module to test is written on the build). Due to this early commit(), the build is left in an intermediate state with the module list unpopulated (=False).
This commit is contained in:
parent
40e502ecd5
commit
97001fbf72
@ -1073,7 +1073,6 @@ class runbot_build(osv.osv):
|
||||
'job_end': False,
|
||||
}
|
||||
build.write(values)
|
||||
cr.commit()
|
||||
else:
|
||||
# check if current job is finished
|
||||
lock_path = build.path('logs', '%s.lock' % build.job)
|
||||
|
Loading…
Reference in New Issue
Block a user