NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-15 23:45:44 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity
18.0
runbot/runbot_merge/changelog/2022-06/empty-body.md
Xavier Morel 3da1874196 [FIX] runbot_merge: correctly handle emptying PR body 
The previous version of the code assumed `pr['body']` is always a
string, which is not correct, when the PR body is emptied the body
itself is removed (its value is `None`).

Add a case for this in the PR edition test, and avoid blowing up (or
adding empty newlines) when the PR body is empty. For PR creation this
issue was fixed in c2db5659d8 but
apparently I missed that the exact same issue occurs just a few lines
above.

Also turns out github does *not* send change information when the body
is updated from (or to?) `None`, so don't even bother with that, just
check every time if the overall message has been updated.

Fixes #629
2022-08-05 15:35:51 +02:00

189 B
Raw Permalink Blame History

FIX: correctly handle PR empty PR descriptions

Github's webhook for this case are weird, and weren't handled correctly, updating a PR's description to or from empty might be mishandled.