mirror of
https://github.com/odoo/runbot.git
synced 2025-03-17 16:35:47 +07:00
1cb31cf2c2
Forgot to bump the version when creating the migration. Also convert the migration to a single sql query, although the migration will never run because I ran the query manually to fix things up after finding out the data was "dirty" since the new code (assuming only modern statuses) was merged without running the migration. Thankfully it looks like the impact was not too severe (because the legacy statuses should only be present on very old commits / PRs), I don't remember when I deployed the update but apparently just a pair of PRs got affected, because their `previous_failure` was the old style and thus broke the "new failure" check.
33 lines
1.2 KiB
Python
33 lines
1.2 KiB
Python
from psycopg2.extras import execute_values
|
|
|
|
|
|
def migrate(cr, version):
|
|
# Drop all legacy style "previous failures": this is for PRs
|
|
# several years old so almost certainly long irrelevant, and it
|
|
# allows removing the workaround for them. Legacy style has the
|
|
# `state`, `target`, `description` keys at the toplevel while new
|
|
# style is like commit statuses, with the contexts at the toplevel
|
|
# and the status info below.
|
|
cr.execute("""
|
|
UPDATE runbot_merge_pull_requests
|
|
SET previous_failure = '{}'
|
|
WHERE previous_failure::jsonb ? 'state'
|
|
""")
|
|
|
|
cr.execute("""
|
|
WITH new_statuses (id, statuses) AS (
|
|
SELECT id, json_object_agg(
|
|
key,
|
|
CASE WHEN jsonb_typeof(value) = 'string'
|
|
THEN jsonb_build_object('state', value, 'target_url', null, 'description', null)
|
|
ELSE value
|
|
END
|
|
) AS statuses
|
|
FROM runbot_merge_commit
|
|
CROSS JOIN LATERAL jsonb_each(statuses::jsonb) s
|
|
WHERE jsonb_path_match(statuses::jsonb, '$.*.type() != "object"')
|
|
GROUP BY id
|
|
)
|
|
UPDATE runbot_merge_commit SET statuses = new_statuses.statuses FROM new_statuses WHERE runbot_merge_commit.id = new_statuses.id
|
|
""")
|