Xavier Morel 1d106f552d [FIX] runbot_merge: missing feedback on fw r+ ... In some cases, feedback to the PR author that an r+ is redundant went missing. This turns out to be due to the convolution of the handling of approval on forward-port, and the fact that the target PR is treated exactly like its ancestors: if the PR is already approved the approval is not even attempted (and so no feedback if it's incorrect). Straighten up this bit and add a special case for the PR being commented on, it should have the usual feedback if in error or already commented on. Furthermore, update `PullRequests._pr_acl` to kinda work out of the box for forward-port: if the current PR is a forward port, `is_reviewer` should check delegation on all ancestors, there doesn't seem to be any reason to split "source_reviewer", "parent_reviewer", and "is_reviewer". Fixes #939		2024-09-05 13:25:19 +02:00
..
changelog	[ADD] *: changelog entries I forgot	2023-08-14 09:28:19 +02:00
data	[IMP] *: trigger-ify task queue type crons	2024-08-02 15:14:50 +02:00
migrations	[CHG] *: rewrite commands set, rework status management	2024-05-23 07:58:46 +02:00
models	[IMP] *: trigger-ify task queue type crons	2024-08-02 15:14:50 +02:00
tests	[FIX] runbot_merge: missing feedback on fw r+	2024-09-05 13:25:19 +02:00
__init__.py	[ADD] mergebot, forwardbot: changelog	2021-10-20 15:16:48 +02:00
__manifest__.py	[CHG] *: rewrite commands set, rework status management	2024-05-23 07:58:46 +02:00
controllers.py	[FIX] forwardport: count next to users should be the fwport	2024-06-28 08:18:34 +02:00