mirror of
https://github.com/odoo/runbot.git
synced 2025-03-19 01:15:48 +07:00
1d106f552d
In some cases, feedback to the PR author that an r+ is redundant went missing. This turns out to be due to the convolution of the handling of approval on forward-port, and the fact that the target PR is treated exactly like its ancestors: if the PR is already approved the approval is not even attempted (and so no feedback if it's incorrect). Straighten up this bit and add a special case for the PR being commented on, it should have the usual feedback if in error or already commented on. Furthermore, update `PullRequests._pr_acl` to kinda work out of the box for forward-port: if the current PR is a forward port, `is_reviewer` should check delegation on all ancestors, there doesn't seem to be any reason to split "source_reviewer", "parent_reviewer", and "is_reviewer". Fixes #939 |
||
|---|---|---|
| .. | ||
| conftest.py | ||
| test_batches.py | ||
| test_conflicts.py | ||
| test_limit.py | ||
| test_overrides.py | ||
| test_simple.py | ||
| test_updates.py | ||
| test_weird.py | ||