Xavier Morel 4bdf7e5eda [FIX] runbot_merge: stagings involving repos w/o required statuses ... PRs transitioning to 'ready' had been checked and tested but turns out I had completely forgotten to test that stagings would validate properly therefore of course they didn't. The issue here was I'd forgotten `''.split(',')` returns `['']` rather than `[]`, so on an empty required_statuses the staging validator would keep looking for a status matching the context `''` and would never find it, keeping the staging pending until timeout. So most likely the problem could have been resolved by just adding a condition to [r.strip() for r in repomap[c.sha].required_statuses.split(',')] but I'd already done all the rest of the reorganisation by that point, test pass and I think it's a somewhat better logic. Therefore I'll go with that for now. * properly handle empty required_statuses during staging validation * remove the final postcondition, if we're missing commits which don't require any statuse we should not care * expand test to include up to merging PRs * automatically create dummy commits when creating stagings, that way the relevant commits are in the database (can't hurt) PS: an other alternative would have been to filter out or skip ahead on commits which don't require any statuses aka cmap & required_statuse / cmap would not even have that entry		2020-02-07 08:29:55 +01:00
..
__init__.py	[ADD] runbot_merge: a merge bot	2018-09-03 13:16:36 +02:00
pull_requests.py	[FIX] runbot_merge: stagings involving repos w/o required statuses	2020-02-07 08:29:55 +01:00
res_partner.py	[FIX] runbot_merge: provide explicit labels on fields	2020-01-13 08:43:10 +01:00