NextERP/design-themes
2
0
Fork 0
mirror of https://github.com/odoo/design-themes.git synced 2025-10-07 01:18:52 +07:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] theme_*: check cta_btn_text is not False before applying upper

Browse Source 
The themes cobalt, paptic and vehicle apply upper on cta_btn_text for some
snippets. In some case cta_btn_text is a boolean (False) and not a string.
We must check cta_btn_text is not False before calling upper on it.

task-2518565

closes odoo/design-themes#33

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
This commit is contained in:
Sébastien Mottet (oms)
2021-07-07 08:52:07 +00:00
parent 1e6f937fce
commit e05e835b28
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
theme_cobalt/views/customizations.xml
+1 -1
View File
@@ -169,7 +169,7 @@
<!-- ==== Call To Action ===== -->
<template id="s_call_to_action" inherit_id="website.s_call_to_action" name="Cobalt s_call_to_action">
<xpath expr="//t[@t-esc='cta_btn_text']" position="replace">
<t t-esc="cta_btn_text.upper()">START NOW</t>
<t t-esc="cta_btn_text and cta_btn_text.upper()">START NOW</t>
</xpath>
</template>
theme_paptic/views/customizations.xml
+1 -1
View File
@@ -52,7 +52,7 @@
<xpath expr="//p[2]" position="replace">
<p class="text-o-color-3">
<a href="#" class="btn btn-lg btn-primary mb-2">START NOW</a>&#160;&#160;&#160;&#160;
<a t-att-href="cta_btn_href" class="btn btn-lg btn-secondary mb-2"><t t-esc="cta_btn_text.upper()">SCHEDULE A DEMO</t></a>
<a t-att-href="cta_btn_href" class="btn btn-lg btn-secondary mb-2"><t t-esc="cta_btn_text and cta_btn_text.upper()">SCHEDULE A DEMO</t></a>
</p>
</xpath>
theme_vehicle/views/customizations.xml
+1 -1
View File
@@ -10,7 +10,7 @@
<font style="font-size: 62px;font-weight: bold;">Start the Engine</font>
</xpath>
<xpath expr="//a[hasclass('btn')]" position="replace">
<a t-att-href="cta_btn_href" class="btn btn-primary btn-lg mb-2"><t t-esc="cta_btn_text.upper()">START THE ENGINE</t></a>
<a t-att-href="cta_btn_href" class="btn btn-primary btn-lg mb-2"><t t-esc="cta_btn_text and cta_btn_text.upper()">START THE ENGINE</t></a>
</xpath>
</template>