mirror of
https://github.com/odoo/runbot.git
synced 2025-03-17 00:15:47 +07:00

Currently, once a source PR has been merged it's not possible to set or update a limit, which can be inconvenient (e.g. people might have forgotten to set it, or realise after the fact that setting one is not useful, or might realise after the fact that they should *unset* it). This PR relaxes that constraint (which is not just a relaxation as it requires a bunch of additional work and validation), it should now be possible to: - update the limit to any target, as long as that target is at or above the current forwardport tip's - with the exception of a tip being forward ported, as that can't be cancelled - resume a forward port stopped by a previously set limit (just increase it to whatever) - set a limit from any forward-port PR - set a limit from a source, post-merge The process should also provide pretty chatty feedback: - feedback on the source and closest root - feedback about adjustments if any (e.g. setting the limit to B but there's already a forward port to C, the 'bot should set the limit to C and tell you that it happened and why) Fixes #506
482 B
482 B
IMP: allow setting forward-port limits after the source pull request has been merged
Should now be possible to both extend and retract the forward port limit afterwards, though obviously no shorter than the current tip of the forward port sequence. One limitation is that forward ports being created can't be stopped so there might be some windows where trying to set the limit to the current tip will fail (because it's in the process of being forward-ported to the next branch).