..cher
Defines dataset directly on website elements such that it can be
overridden by other modules if necessary.
This was done due to the override in the `test_themes` module completely
overriding all attributes of the website_switcher's dropdown items.
Runbot Error 106501
closesodoo/design-themes#1027
X-original-commit: c5f4e1c414
Related: odoo/odoo#190475
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>
*: anelusia, anelusia, enark, kiddo, loftspace, notes
- Install Website e-commerce.
- Select the "Kea" theme for your website.
- Go to the "/shop" page.
- Click on "Desks" category to go to the "/shop/category/desks-1" page.
- Click on edit to enter edit mode.
- Click on the "theme" tab.
- Change the website background color to "black".
- Bug: The breadcrumb has an ugly white background instead of no
background color, as in the "default" theme. Also, the "active"
breadcrumb item is hidden due to white text on a white background.
This commit removes the white background from the breadcrumb for all
themes that use it. This ensures the same appearance as other themes.
opw-4232082
closesodoo/design-themes#1016
X-original-commit: fe91239586
Signed-off-by: Serge Bayet (seba) <seba@odoo.com>
In some theme customizations, some replaced images do not have the usual
image classes `img img-fluid mx-auto` anymore. The `img-fluid` one is
needed for grid images in mobile view, as they are overflowing without
it.
This commit adds these missing classes on the identified problematic
images.
closesodoo/design-themes#998
X-original-commit: c5adf9a903
Related: odoo/odoo#185404
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
In order to simplify the tours API, it was decided to remove the
extra_trigger key from the steps.
To check that an element is in the DOM, simply create a step with
a trigger.
task~3974087
closesodoo/design-themes#816
Related: odoo/odoo#171309
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
For each theme, there are files redefining the different website SCSS
variables, in order for the color palettes, fonts, buttons,... to have
the styles defined by them. These redefinitions are also used by the
"Theme Options", to show the current values in the different widgets.
In order for the primary buttons to be "outlined", the "Enark" theme set
the `btn-primary-outline` variable to `'true'`. However, this value
should be a boolean instead of a string. Indeed, since the option does
not recognize the string value, the "Buttons Primary Style" widget
therefore shows a "/" instead of "Outline", which is not correct.
This commit fixes this by setting a boolean value.
opw-3957157
closesodoo/design-themes#814
X-original-commit: 14ff983da2
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Currently, in tour_compiler, to check that an element is actually
present in the DOM in a step, there are 2 possibilities.
- `isCheck: true` => Checks that the element is in the DOM.
The latter can be disabled.
- `run() {}` => Checks that the element is in the DOM (because this
is what is done by default). However, if the element is disabled,
the step will be aborted.
In the codebase, we can see a lot of `run() {} //it's a check` and
`isCheck:true`. However, the behavior is not exactly the same.
What's more, there are 2 ways to do "the same thing".
In order to clarify the turns API, it was decided to no longer put an
action (step.run) by default. (Previously, the default action was
the "click" action).
From then on, it is no longer necessary to stipulate
`step.isCheck: true` nor `run() {}`.
The corollary is that now, you must explicitly write `run: click`, if
you want the click action to be triggered on the target.
This commit sets the stage for making this change.
closesodoo/design-themes#801
Related: odoo/odoo#167743
Related: odoo/enterprise#63711
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
The following commit [1] added a test to verify that there are no
duplicate classes in the elements of predefined page templates.
This test worked fine until it failed when we attempted to merge a
commit in which a template is rendered with empty spaces in the class
attribute of an element. The test considered the empty spaces as classes
and therefore assumed that two identical classes existed.
This commit excludes empty spaces when retrieving classes in this test.
[1]: https://github.com/odoo/design-themes/commit/758e2ab819df37c56103b1e82f1e6358b3dba00c
task-3662985
closesodoo/design-themes#792
X-original-commit: 05cfe05280
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
Some themes were making the s_picture image responsive on their own. It
is now done generically, so the theme extensions must be removed to be
able to merge.
task-3266862
closesodoo/design-themes#787
X-original-commit: 08cb536b02
Related: odoo/odoo#157813
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit removes the overrides of scss variables that are set to the
default value and duplicated overrides.
task-2463604
closesodoo/design-themes#768
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>
In this commit, we change rest of triggers in tours where an iframe is
selected (suite of #156653).
To do this, we use the :iframe HOOT pseudo-selector.
With this changes, we can now remove the getNodesFromSelector
function in odoo/addons/web_tour/static/src/tour_service/tour_utils.js
Note that in this previous function, a ([is-ready]="true") check was
made for iframe elements but was only necessary for few of them (7).
So, a stepUtils.waitIframeIsReady() has been added to check this state.
closesodoo/design-themes#783
Related: odoo/odoo#157217
Related: odoo/enterprise#58474
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
In PR [1], the duplicated navbars ids `o_main_nav` and `top_menu` are
replaced by classes, to avoid having the same ids multiple times in the
DOM. Note that for stability, the ids are kept for the desktop view
navbar.
This commit adapts the tests so they now consider the classes and not
the ids.
[1]: https://github.com/odoo/odoo/pull/146492
task-3609531
closesodoo/design-themes#780
X-original-commit: 103e544835
Related: odoo/odoo#156013
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Commit [1] introduced a new test that uninstalls theme_buzzy. This leads
to the whole module being uninstalled because this module has all themes
as dependencies.
To fix this, we just run the test as the last test, ensuring the module
is still installed for other tests.
Ideally, tests would be independent from one another, but for now, the
order matters.
[1]: https://github.com/odoo/design-themes/commit/4cdd1db20c021ebd369b46c739591def9732eec5closesodoo/design-themes#782
X-original-commit: 45e9374699
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
Commit [1] introduced new images for the theme, alongside their related
ir.attachment definition. Later, a refactoring of the theme was made at
commit [2]. During that refactoring, multiple mistakes were made. Three
image files were removed: s_image_text.jpg, s_text_image.jpg and
s_banner.jpg. Out of these 3, only one related ir.attachment was
adapted to not use the removed image anymore: s_banner. Thus this left
two dead ir.attachment pointing to images that do not exist anymore.
Note that the banner image was actually restored later at [3]. Until
there... just dead code, although it could potentially be used and crash
by custo (this is why this targets the same version as [2]). Indeed, [2]
also patched the use of those two removed images in their related
snippet by changing the related image sources directly (using a special
route of the web_editor which generates SVG).
However, in [4], we started using one of those two images (via its xmlid
/ key) in another snippet: the new image snippet. This thus break the
kea theme when using that new snippet because the ir.attachment that is
used for that image still referenced an image that was removed by [2].
[1]: https://github.com/odoo/design-themes-old/commit/66bf0fc439f8549b00cbdf2eaa2b9517b6ac9876
[2]: https://github.com/odoo/design-themes/commit/004e38398a98ba61e587bf12b8bfc5e396baa434
[3]: https://github.com/odoo/design-themes/commit/5b8e14b83dba05e23d2a20418484b56b5f3b05cc
[4]: https://github.com/odoo/odoo/commit/507b80a12574ce19bcb925d88868fb377b1c4b06
opw-3689096
closesodoo/design-themes#777
X-original-commit: 5778e692f9
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit addresses the issue with the customization of the s_picture
snippet within the theme_vehicle. Previously, this snippet enforced a
column height, which cannot be modified using the editor. Themes should
not impose customizations that users are unable to adjust using the
editor.
See also : odoo/odoo#145413
task-3626753
Part-of: odoo/design-themes#753
To make sure the required primary templates have been generated from
the theme's manifest when inherited views are imported/updated, this
commit triggers their generation from a first imported XML file.
This has been added to all themes for consistency, even the ones that
do not require it currently.
Related to https://github.com/odoo/odoo/pull/148443
task-3670496
X-original-commit: 22abe61eaf
Part-of: odoo/design-themes#761
Odoo Translation Bot