For each theme, there are files redefining the different website SCSS
variables, in order for the color palettes, fonts, buttons,... to have
the styles defined by them. These redefinitions are also used by the
"Theme Options", to show the current values in the different widgets.
In order for the primary buttons to be "outlined", the "Enark" theme set
the `btn-primary-outline` variable to `'true'`. However, this value
should be a boolean instead of a string. Indeed, since the option does
not recognize the string value, the "Buttons Primary Style" widget
therefore shows a "/" instead of "Outline", which is not correct.
This commit fixes this by setting a boolean value.
opw-3957157
closesodoo/design-themes#807
X-original-commit: 14ff983da2
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Commit [1] introduced new images for the theme, alongside their related
ir.attachment definition. Later, a refactoring of the theme was made at
commit [2]. During that refactoring, multiple mistakes were made. Three
image files were removed: s_image_text.jpg, s_text_image.jpg and
s_banner.jpg. Out of these 3, only one related ir.attachment was
adapted to not use the removed image anymore: s_banner. Thus this left
two dead ir.attachment pointing to images that do not exist anymore.
Note that the banner image was actually restored later at [3]. Until
there... just dead code, although it could potentially be used and crash
by custo (this is why this targets the same version as [2]). Indeed, [2]
also patched the use of those two removed images in their related
snippet by changing the related image sources directly (using a special
route of the web_editor which generates SVG).
However, in [4], we started using one of those two images (via its xmlid
/ key) in another snippet: the new image snippet. This thus break the
kea theme when using that new snippet because the ir.attachment that is
used for that image still referenced an image that was removed by [2].
[1]: https://github.com/odoo/design-themes-old/commit/66bf0fc439f8549b00cbdf2eaa2b9517b6ac9876
[2]: https://github.com/odoo/design-themes/commit/004e38398a98ba61e587bf12b8bfc5e396baa434
[3]: https://github.com/odoo/design-themes/commit/5b8e14b83dba05e23d2a20418484b56b5f3b05cc
[4]: https://github.com/odoo/odoo/commit/507b80a12574ce19bcb925d88868fb377b1c4b06
opw-3689096
closesodoo/design-themes#770
X-original-commit: 5778e692f9
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit rephrases one of the quotes block's sentences to use the
word "academic" instead of "diplomatic".
closesodoo/design-themes#737
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Themes translation in Odoo 16 have been lost, they were not exported on
Transifex anymore (bug).
We just added back the repository on it, and our internal translators
are working on those translations.
They found some typos and bad wording which are fixed here.
Technically, note that we need the themes fully translated for the
chatGPT integration coming in website configurator.
Indeed, if a theme is not (almost fully) translated, it won't be using
chatGPT for text replacement.
This is because if we ask chatGPT to do text replacement and translation
at the same time, it just provides bad results.
See https://github.com/odoo/odoo/pull/137703closesodoo/design-themes#717
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit disables the warning (introduced by the community commit)
when test-themes is installed, as a lot of websites are created and are
not necessary when testing the different themes.
-- ORIGINAL COMMIT MESSAGE --
Prior to this commit, if a website does not have a domain, nothing tells
the user that this is a misconfiguration that can lead to broken
behaviours. For example, here are the steps to reproduce:
- Have two website (X and Y)
- Website Y does not have a domain
- Tab 1 has Website X selected
- User opens a new tab
- Tab 2 has Website X selected as well
- User switches tab 2 to Website Y
- No redirection happens
- User switches back to tab 1
- User opens the HTML editor for Website X
- Website X content is displayed
- User saves
- Content is saved on Website Y
This is pretty hard to fix as a lot of the python flow for Website uses
`get_current_website` which will uses the session's "force_website_id"
in priority.
In any case, we consider having multiple websites sharing the same
domain (or having no domains at all) a misconfiguration. Therefore, we
should warn the user of so.
This commit adds a tooltip on the website switcher for websites that do
not have a domain set. It also adds a notification recommending users
close other tabs if they switch website.
opw-3374214
closesodoo/design-themes#675
Related: odoo/odoo#128979
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
This commit permits to use the new utility to enter in edit mode. This
way, we make sure that the edit mode is enabled before testing the next
step of the test. This avoids race conditions during tests.
task-3203820
closesodoo/design-themes#650
Related: odoo/odoo#118849
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
* theme_bookstore, theme_clean, theme_enark, theme_kiddo,
theme_loftspace, theme_odoo_experts, theme_orchid
This commit will rename the font "Muli" to "Mulish" as it has been
renamed in Google Fonts.
Closes#574
Courtesy of Kaushalya Mandaliya <kma@odoo.com>
closesodoo/design-themes#634
Related: odoo/odoo#114810
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
In [1], in master, the `content` class is removed from the elements
with the `row` class in the Carousel snippet. This commit does the same
for the extension of Carousel in the "Clean" theme, to be consistent
with these changes.
[1]: https://github.com/odoo/odoo/pull/102696
task-3011192
closesodoo/design-themes#627
X-original-commit: 6232ec4af4
Related: odoo/odoo#108642
Signed-off-by: Vray Benjamin (bvr) <bvr@odoo.com>
Signed-off-by: Bojabza Soukéina (sobo) <sobo@odoo.com>
Commit [1] refreshed the design of the KEA theme but unfortunately
introduced the wrong path to a shape on the s_picture snippet.
This used to cause a traceback but [2] fixed it. However, it is still
worth correcting the path so that shapes automatically chain under the
s_picture snippet of that theme.
To do so, a simple check is added when the option computes the next
shape, and looks for the broken path, if it finds it, it corrects it.
Steps to reproduce:
- Use the KEA theme
- Drop the "Picture" snippet
- Drop the text snippet under it
- Enable the background shape option for the text snippet
- The first shape is selected instead of the next one in the series.
To fix properly in master of course.
[1]: https://github.com/odoo/design-themes/commit/88b81d41dadbfaad5d0b36ba2f1c595e309438ba
[2]: https://github.com/odoo/odoo/commit/e985f8ef7a358c5aae9245267e18e65ea8383400
opw-3082292
closesodoo/design-themes#622
X-original-commit: f3bd5ab20b
Related: odoo/odoo#108451
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
In [1], in order to allow back the edition of the images of the columns
in grid mode containing only an image, the `contenteditable` property
is removed from these columns.
This commit removes the `contenteditable` property that was set on an
image column of the Masonry snippet in the Zap theme.
[1]: https://github.com/odoo/odoo/pull/103767
opw-3028116
closesodoo/design-themes#616
Related: odoo/odoo#103767
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Since [1], the themes installed in the `_post_init` hook of test_themes
would not go through the `_post_copy()` anymore.
It is not a big deal as this module purpose is to ease our tests and
quickly being able to navigate through themes when we need to, but still
this is something that need to be fixed as otherwise the themes would
not really reflect how they look like.
Typically, go to the Odoo Experts theme, which is supposed to have the
"Contact" header template, it will not have that header layout.
[1]: https://github.com/odoo/odoo/commit/b8a24efa71daea1f96465b780f4f0e384ce74703closesodoo/design-themes#614
X-original-commit: fea847977d
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
This is the direct following of the PR [1].
Some themes "hard code" the background colors of some snippets, which
prevents the user to change it with a preset color without deleting the
current background first.
This commit does two things:
- remove the problematic hard coded background colors;
- replace the colors that are removed by some themes by the ones that
were set in [1] (for the searchbar and text highlight snippets).
[1]: https://github.com/odoo/odoo/pull/90749
task-2824393
closesodoo/design-themes#563
Related: odoo/odoo#90749
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The Masonry snippet has been modified to be only in grid mode
and its templates have therefore been changed.
This commit adapts the themes that modify the Masonry templates to be
in accordance with these changes.
See community counterpart for details.
task-2973198
closesodoo/design-themes#592
Related: odoo/odoo#99857
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit, if a theme wanted to define a main font for their
theme and let the "headings", "navbar" and "buttons" ones use the same
they had to add this in their map:
```
'font': XXX,
'headings-font': null,
'navbar-font': null,
'button-font': null,
```
Indeed, without setting the "null" values, those font would use YYY
which is the first font defined in the theme config, which might be
different from XXX. And if forcing XXX 4 times, like most themes do at
the moment, if the user wanted to change them all, he had to change the
4 ones instead of the main one.
Now, only the 'font' value use the first font defined in the theme
config if not explicitly set. So forcing the null values is not
necessary, it will be the default behavior.
The advantage is thus also functional, as most theme forced all their 4
fonts so changing the main one did not change the others.
task-2993054
closesodoo/design-themes#591
Related: odoo/odoo#100867
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
New test was introduced with [1] but it actually sometimes lead to
timeout errors.
That's a common issue since we merged the frontend in the backend and
some tour (like this one) now have to start both the backend and the
frontend (in the iframe).
10 seconds is not enough to load both, it often miss just half a second.
[1]: https://github.com/odoo/design-themes/commit/0e2497b8e84eab8957028f4d63ff0899a9fe6ab3
runbot-4684
closesodoo/design-themes#587
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit introduces a new theme for tests purpose.
The goal is to be able to create records and simulate a real use case
without only testing through unit tests in python.
For instance, with this commit, we now fully test:
- menu creation
- page creation
- new header & footer template
- new image shape & background shape
This will be extended later to be able to test other stuff too, maybe
like changing the website logo (not supported yet). Also, our existing
standalone test in themes should use this theme instead of nano to not
rely on a real theme that might change.
Courtesy of NMI as this theme is partly based on his job.
closesodoo/design-themes#586
Related: odoo/odoo#99099
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The callstack is:
- _pre_dispatch() (http_routing)
- super()
- _frontend_pre_dispatch()
- super()
- _frontend_pre_dispatch() (website) -> Set the website on request
But in `test_themes` we were forcing the website in a `_pre_dispatch()`
override, after calling `super()`.
It means that the call to `_frontend_pre_dispatch()` was actually done
without having yet forced the website in session. get_current_website()
would then not consider the `fw` param as not yet in session, and the
request.website would be set to 1, the default one.
Later in the business code, there would be a mismatch between
`request.website` and `get_current_website()`.
closesodoo/design-themes#582
Related: odoo/odoo#98200
Related: odoo/enterprise#30691
Related: odoo/upgrade#3808
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Soukéina Bojabza